* [PATCH] no TIOCSBRK/TIOCCBRK in ia32 emulation on amd64
@ 2004-10-19 22:07 Werner Almesberger
2004-10-19 22:39 ` Andi Kleen
0 siblings, 1 reply; 2+ messages in thread
From: Werner Almesberger @ 2004-10-19 22:07 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton, ak, Jaakko Hyvätti
In ia32 emulation, the amd64 kernel refuses the ioctls TIOCSBRK
and TIOCCBRK with EINVAL. I've attached a patch that adds them to
the compatibility list.
Since all architectures have these ioctls ("m68knommu" inherits
them from "m68k", "um" from its host) and use the same code, I
think adding them to compat_ioctl.h is the correct choice (as
opposed to adding them to arch/x86_64/ia32/ia32_ioctl.c).
The patch is for 2.6.9. I've observed the problem the first time
in 2.6.7.
- Werner
---------------------------------- cut here -----------------------------------
Signed-off-by: Werner Almesberger <werner@almesberger.net>
--- linux-2.6.9/include/linux/compat_ioctl.h.orig 2004-10-19 18:52:50.406756352 -0300
+++ linux-2.6.9/include/linux/compat_ioctl.h 2004-10-19 18:56:34.057756232 -0300
@@ -23,6 +23,8 @@
COMPATIBLE_IOCTL(TCSETSW)
COMPATIBLE_IOCTL(TCSETSF)
COMPATIBLE_IOCTL(TIOCLINUX)
+COMPATIBLE_IOCTL(TIOCSBRK)
+COMPATIBLE_IOCTL(TIOCCBRK)
/* Little t */
COMPATIBLE_IOCTL(TIOCGETD)
COMPATIBLE_IOCTL(TIOCSETD)
--
_________________________________________________________________________
/ Werner Almesberger, Buenos Aires, Argentina werner@almesberger.net /
/_http://www.almesberger.net/____________________________________________/
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] no TIOCSBRK/TIOCCBRK in ia32 emulation on amd64
2004-10-19 22:07 [PATCH] no TIOCSBRK/TIOCCBRK in ia32 emulation on amd64 Werner Almesberger
@ 2004-10-19 22:39 ` Andi Kleen
0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2004-10-19 22:39 UTC (permalink / raw)
To: Werner Almesberger; +Cc: linux-kernel, Andrew Morton, ak, Jaakko Hyv?tti
On Tue, Oct 19, 2004 at 07:07:05PM -0300, Werner Almesberger wrote:
> In ia32 emulation, the amd64 kernel refuses the ioctls TIOCSBRK
> and TIOCCBRK with EINVAL. I've attached a patch that adds them to
> the compatibility list.
>
> Since all architectures have these ioctls ("m68knommu" inherits
> them from "m68k", "um" from its host) and use the same code, I
> think adding them to compat_ioctl.h is the correct choice (as
> opposed to adding them to arch/x86_64/ia32/ia32_ioctl.c).
>
> The patch is for 2.6.9. I've observed the problem the first time
> in 2.6.7.
Thanks, looks good.
-Andi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-10-20 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-19 22:07 [PATCH] no TIOCSBRK/TIOCCBRK in ia32 emulation on amd64 Werner Almesberger
2004-10-19 22:39 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®