mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Kim Holviala <kim@holviala.com>
Cc: linux-kernel@vger.kernel.org, vojtech@suse.cz
Subject: Re: [PATCH] mousedev: Fix scrollwheel thingy on IBM ScrollPoint mice
Date: Tue, 26 Oct 2004 17:11:57 -0700	[thread overview]
Message-ID: <20041026171157.21c7a15a.akpm@osdl.org> (raw)
In-Reply-To: <417E0EA8.7000704@holviala.com>

Kim Holviala <kim@holviala.com> wrote:
>
> The scrollwheel thingy (stick) on IBM ScrollPoint mice returns extremely
> aggressive values even when touched lightly. This confuses XFree which
> assumes the wheel values can only be 1 or -1. Incidently, it also
> confuses Windows' default mouse driver which proves the problem is in
> the mouse itself.
> 
> This patch limits the scroll wheel movements to be either +1 or -1 on
> the event -> emulated PS/2 level. I chose to implement it there because
> mousedev emulates Microsoft mice but the real ones almoust never return
> a bigger value than 1 (or -1).
> ...
> +#ifdef CONFIG_INPUT_MOUSEDEV_WHEELFIX
> +				if (value) { value = (value < 0 ? -1 : 1); }
> +#endif /* CONFIG_INPUT_MOUSEDEV_WHEELFIX */

This is really not a thing which we can put behind compile-time config.

Can we come up with a fix which works correctly on all hardware?  If not,
this workaround will need to be enabled by some sort of runtime detection.


  reply	other threads:[~2004-10-27  0:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-26  8:45 Kim Holviala
2004-10-27  0:11 ` Andrew Morton [this message]
2004-10-27  0:33   ` Dmitry Torokhov
2004-10-27  5:51     ` Vojtech Pavlik
2004-10-27  6:29       ` Dmitry Torokhov
2004-10-27  6:32       ` Kim Holviala
2004-10-28 12:42         ` Kim Holviala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041026171157.21c7a15a.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=kim@holviala.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®