From: Kim Holviala <kim@holviala.com>
To: linux-kernel@vger.kernel.org, vojtech@suse.cz
Subject: [PATCH] mousedev: Fix scrollwheel thingy on IBM ScrollPoint mice
Date: Tue, 26 Oct 2004 11:45:28 +0300 [thread overview]
Message-ID: <417E0EA8.7000704@holviala.com> (raw)
The scrollwheel thingy (stick) on IBM ScrollPoint mice returns extremely
aggressive values even when touched lightly. This confuses XFree which
assumes the wheel values can only be 1 or -1. Incidently, it also
confuses Windows' default mouse driver which proves the problem is in
the mouse itself.
This patch limits the scroll wheel movements to be either +1 or -1 on
the event -> emulated PS/2 level. I chose to implement it there because
mousedev emulates Microsoft mice but the real ones almoust never return
a bigger value than 1 (or -1).
Kim
diff -ruN linux-2.6.8.1-original/drivers/input/Kconfig linux-2.6.8.1/drivers/input/Kconfig
--- linux-2.6.8.1-original/drivers/input/Kconfig 2004-10-26 08:42:30.000000000 +0300
+++ linux-2.6.8.1/drivers/input/Kconfig 2004-10-26 09:54:58.000000000 +0300
@@ -72,6 +72,17 @@
screen resolution you are using to correctly scale the data. If
you're not using a digitizer, this value is ignored.
+config INPUT_MOUSEDEV_WHEELFIX
+ bool "Limit too fast wheel movement"
+ depends on INPUT_MOUSEDEV
+ default n
+ help
+ Say Y here if your mouse wheel only works randomly or if it scrolls
+ too fast. Some mice, like IBM's scrollpoints, return too big wheel
+ movement values which confuse programs like XFree.
+
+ If your mouse wheel thingy works as advertised, say N.
+
config INPUT_JOYDEV
tristate "Joystick interface"
depends on INPUT
diff -ruN linux-2.6.8.1-original/drivers/input/mousedev.c linux-2.6.8.1/drivers/input/mousedev.c
--- linux-2.6.8.1-original/drivers/input/mousedev.c 2004-10-26 08:42:31.000000000 +0300
+++ linux-2.6.8.1/drivers/input/mousedev.c 2004-10-26 11:21:01.000000000 +0300
@@ -137,7 +137,11 @@
switch (code) {
case REL_X: mousedev->packet.dx += value; break;
case REL_Y: mousedev->packet.dy -= value; break;
- case REL_WHEEL: mousedev->packet.dz -= value; break;
+ case REL_WHEEL:
+#ifdef CONFIG_INPUT_MOUSEDEV_WHEELFIX
+ if (value) { value = (value < 0 ? -1 : 1); }
+#endif /* CONFIG_INPUT_MOUSEDEV_WHEELFIX */
+ mousedev->packet.dz -= value; break;
}
}
next reply other threads:[~2004-10-26 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-26 8:45 Kim Holviala [this message]
2004-10-27 0:11 ` Andrew Morton
2004-10-27 0:33 ` Dmitry Torokhov
2004-10-27 5:51 ` Vojtech Pavlik
2004-10-27 6:29 ` Dmitry Torokhov
2004-10-27 6:32 ` Kim Holviala
2004-10-28 12:42 ` Kim Holviala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=417E0EA8.7000704@holviala.com \
--to=kim@holviala.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome