* Re: Parenthize nth_page() macro arg, in linux/mm.h. [not found] <200411140517.iAE5HOqM010399@hera.kernel.org> @ 2004-11-14 6:10 ` William Lee Irwin III 2004-11-14 6:18 ` Al Viro 0 siblings, 1 reply; 3+ messages in thread From: William Lee Irwin III @ 2004-11-14 6:10 UTC (permalink / raw) To: Linux Kernel Mailing List; +Cc: jgarzik, viro On Sat, Nov 13, 2004 at 07:43:08PM +0000, Linux Kernel Mailing List wrote: > ChangeSet 1.2092.7.2, 2004/11/13 14:43:08-05:00, jgarzik@pobox.com > Parenthize nth_page() macro arg, in linux/mm.h. > mm.h | 2 +- > 1 files changed, 1 insertion(+), 1 deletion(-) > diff -Nru a/include/linux/mm.h b/include/linux/mm.h > --- a/include/linux/mm.h 2004-11-13 21:17:35 -08:00 > +++ b/include/linux/mm.h 2004-11-13 21:17:35 -08:00 > @@ -41,7 +41,7 @@ > #define MM_VM_SIZE(mm) TASK_SIZE > #endif > -#define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + n) > +#define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + (n)) Okay, #1 the ((page)) thing should be unnecessary. If it is necessary, arch code is broken, which leads to #2: this came about because alpha wasn't parenthesizing its args in pfn_to_page(); where did the fix for that go? -- wli ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Parenthize nth_page() macro arg, in linux/mm.h. 2004-11-14 6:10 ` Parenthize nth_page() macro arg, in linux/mm.h William Lee Irwin III @ 2004-11-14 6:18 ` Al Viro 2004-11-14 6:23 ` William Lee Irwin III 0 siblings, 1 reply; 3+ messages in thread From: Al Viro @ 2004-11-14 6:18 UTC (permalink / raw) To: William Lee Irwin III; +Cc: Linux Kernel Mailing List, jgarzik On Sat, Nov 13, 2004 at 10:10:16PM -0800, William Lee Irwin III wrote: > On Sat, Nov 13, 2004 at 07:43:08PM +0000, Linux Kernel Mailing List wrote: > > ChangeSet 1.2092.7.2, 2004/11/13 14:43:08-05:00, jgarzik@pobox.com > > Parenthize nth_page() macro arg, in linux/mm.h. > > mm.h | 2 +- > > 1 files changed, 1 insertion(+), 1 deletion(-) > > diff -Nru a/include/linux/mm.h b/include/linux/mm.h > > --- a/include/linux/mm.h 2004-11-13 21:17:35 -08:00 > > +++ b/include/linux/mm.h 2004-11-13 21:17:35 -08:00 > > @@ -41,7 +41,7 @@ > > #define MM_VM_SIZE(mm) TASK_SIZE > > #endif > > -#define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + n) > > +#define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + (n)) > > Okay, #1 the ((page)) thing should be unnecessary. If it is necessary, > arch code is broken, which leads to #2: this came about because alpha > wasn't parenthesizing its args in pfn_to_page(); where did the fix for > that go? In my tree; I'm preparing -bk23-bird1 right now, will post in an hour or so. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Parenthize nth_page() macro arg, in linux/mm.h. 2004-11-14 6:18 ` Al Viro @ 2004-11-14 6:23 ` William Lee Irwin III 0 siblings, 0 replies; 3+ messages in thread From: William Lee Irwin III @ 2004-11-14 6:23 UTC (permalink / raw) To: Al Viro; +Cc: Linux Kernel Mailing List, jgarzik On Sat, Nov 13, 2004 at 10:10:16PM -0800, William Lee Irwin III wrote: >> Okay, #1 the ((page)) thing should be unnecessary. If it is necessary, >> arch code is broken, which leads to #2: this came about because alpha >> wasn't parenthesizing its args in pfn_to_page(); where did the fix for >> that go? On Sun, Nov 14, 2004 at 06:18:56AM +0000, Al Viro wrote: > In my tree; I'm preparing -bk23-bird1 right now, will post in an hour or so. Sounds good to me. Thanks for clearing up my misunderstanding. -- wli ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-11-14 6:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200411140517.iAE5HOqM010399@hera.kernel.org>
2004-11-14 6:10 ` Parenthize nth_page() macro arg, in linux/mm.h William Lee Irwin III
2004-11-14 6:18 ` Al Viro
2004-11-14 6:23 ` William Lee Irwin III
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome