mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: "Mark F. Haigh" <Mark.Haigh@SpirentCom.COM>
Cc: chrisw@osdl.org, linux-security-module@wirex.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/fork.c: VM accounting bugfix (2.6.11-rc3-bk5)
Date: Tue, 8 Feb 2005 23:04:47 -0800	[thread overview]
Message-ID: <20050208230447.V24171@build.pdx.osdl.net> (raw)
In-Reply-To: <420988C1.5030408@spirentcom.com>; from Mark.Haigh@SpirentCom.COM on Tue, Feb 08, 2005 at 07:51:29PM -0800

Hi Mark,

* Mark F. Haigh (Mark.Haigh@SpirentCom.COM) wrote:
> [Aargh!  Missing Signed-off-by.]
> 
> Unless I'm missing something, in kernel/fork.c, dup_mmap():
> 
> 			if (security_vm_enough_memory(len))
> 				goto fail_nomem;
> /* ... */
> fail_nomem:
> 	retval = -ENOMEM;
> 	vm_unacct_memory(charge);
> /* ... */
> 
> If security_vm_enough_memory() fails there, then we vm_unacct_memory()
> that we never accounted (if security_vm_enough_memory() fails, no memory
> is accounted).

You missed one subtle point.  That failure case actually unaccts 0 pages
(note the use of charge).  Not the nicest, but I believe correct.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

  reply	other threads:[~2005-02-09  7:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-09  3:51 Mark F. Haigh
2005-02-09  7:04 ` Chris Wright [this message]
2005-02-09 12:30   ` Hugh Dickins
2005-02-09 19:28     ` Chris Wright
2005-02-09 19:46       ` Hugh Dickins
2005-02-09 20:04   ` Mark F. Haigh
  -- strict thread matches above, loose matches on Subject: below --
2005-02-09  3:48 Mark F. Haigh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050208230447.V24171@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=Mark.Haigh@SpirentCom.COM \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@wirex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®