From: Hugh Dickins <hugh@veritas.com>
To: Chris Wright <chrisw@osdl.org>
Cc: "Mark F. Haigh" <Mark.Haigh@SpirentCom.COM>,
linux-security-module@wirex.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/fork.c: VM accounting bugfix (2.6.11-rc3-bk5)
Date: Wed, 9 Feb 2005 12:30:24 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.61.0502091223310.5842@goblin.wat.veritas.com> (raw)
In-Reply-To: <20050208230447.V24171@build.pdx.osdl.net>
On Tue, 8 Feb 2005, Chris Wright wrote:
> * Mark F. Haigh (Mark.Haigh@SpirentCom.COM) wrote:
> >
> > If security_vm_enough_memory() fails there, then we vm_unacct_memory()
> > that we never accounted (if security_vm_enough_memory() fails, no memory
> > is accounted).
>
> You missed one subtle point. That failure case actually unaccts 0 pages
> (note the use of charge). Not the nicest, but I believe correct.
Not quite: Mark's patch is worse than unnecessary, it's wrong.
dup_mmap's charge starts out at 0 and gets added to each time around
the loop through vmas; if security_vm_enough_memory fails at any point
in that loop, we need to vm_unacct_memory the charge already accumulated.
Hugh
next prev parent reply other threads:[~2005-02-09 12:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-09 3:51 Mark F. Haigh
2005-02-09 7:04 ` Chris Wright
2005-02-09 12:30 ` Hugh Dickins [this message]
2005-02-09 19:28 ` Chris Wright
2005-02-09 19:46 ` Hugh Dickins
2005-02-09 20:04 ` Mark F. Haigh
-- strict thread matches above, loose matches on Subject: below --
2005-02-09 3:48 Mark F. Haigh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0502091223310.5842@goblin.wat.veritas.com \
--to=hugh@veritas.com \
--cc=Mark.Haigh@SpirentCom.COM \
--cc=chrisw@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@wirex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®