From: Jody McIntyre <scjody@steamballoon.com>
To: Pavel Machek <pavel@suse.cz>
Cc: Andrew Morton <akpm@osdl.org>,
bcollins@debian.org, ncunningham@cyclades.com,
bernard@blackham.com.au, torvalds@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: FIx u32 vs. pm_message_t confusion in firewire
Date: Tue, 15 Feb 2005 17:12:42 -0500 [thread overview]
Message-ID: <20050215221242.GO9231@conscoop.ottawa.on.ca> (raw)
In-Reply-To: <20050215004759.GE5415@elf.ucw.cz>
On Tue, Feb 15, 2005 at 01:47:59AM +0100, Pavel Machek wrote:
> Hi!
>
> This should fix u32 vs. pm_message_t confusion in firewire. No code
> changes. Please apply,
> Pavel
Applied to 1394 SVN and development bitkeeper. I will send this
upstream sometime after 2.6.11.
Thanks,
Jody
> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
> --- clean-mm/drivers/ieee1394/nodemgr.c 2005-02-15 00:46:40.000000000 +0100
> +++ linux-mm/drivers/ieee1394/nodemgr.c 2005-02-15 01:04:10.000000000 +0100
> @@ -1284,7 +1284,7 @@
>
> if (ud->device.driver &&
> (!ud->device.driver->suspend ||
> - ud->device.driver->suspend(&ud->device, 0, 0)))
> + ud->device.driver->suspend(&ud->device, PMSG_SUSPEND, 0)))
> device_release_driver(&ud->device);
> }
> up_write(&ne->device.bus->subsys.rwsem);
> --- clean-mm/drivers/ieee1394/ohci1394.c 2005-02-15 00:46:40.000000000 +0100
> +++ linux-mm/drivers/ieee1394/ohci1394.c 2005-02-15 01:04:10.000000000 +0100
> @@ -3546,7 +3546,7 @@
> }
>
>
> -static int ohci1394_pci_suspend (struct pci_dev *pdev, u32 state)
> +static int ohci1394_pci_suspend (struct pci_dev *pdev, pm_message_t state)
> {
> #ifdef CONFIG_PMAC_PBOOK
> {
>
>
> --
> People were complaining that M$ turns users into beta-testers...
> ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
--
next prev parent reply other threads:[~2005-02-16 3:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-14 5:43 PATCH: Address lots of pending pm_message_t changes Nigel Cunningham
2005-02-14 21:34 ` Pavel Machek
2005-02-14 21:46 ` Andrew Morton
2005-02-14 21:57 ` Nigel Cunningham
2005-02-14 22:04 ` Pavel Machek
2005-02-14 22:09 ` Nigel Cunningham
2005-02-14 23:41 ` Pavel Machek
2005-02-15 0:15 ` Nigel Cunningham
2005-02-15 0:15 ` Pavel Machek
2005-02-15 0:21 ` Nigel Cunningham
2005-02-15 1:13 ` Bernard Blackham
2005-02-15 0:31 ` Fix pm_message_t in generic code [was Re: PATCH: Address lots of pending pm_message_t changes] Pavel Machek
2005-02-15 0:46 ` Nigel Cunningham
2005-02-15 0:39 ` Fix u32 vs. pm_message_t in USB " Pavel Machek
2005-02-17 23:40 ` Greg KH
2005-02-28 1:24 ` Pavel Machek
2005-02-15 0:41 ` Fix u32 vs. pm_message_t confusion in OSS Pavel Machek
2005-02-15 0:46 ` Fix u32 vs. pm_message_t confusion in PCMCIA Pavel Machek
2005-02-15 0:47 ` FIx u32 vs. pm_message_t confusion in firewire Pavel Machek
2005-02-15 22:12 ` Jody McIntyre [this message]
2005-02-15 0:51 ` Fix u32 vs. pm_message_t in network device drivers Pavel Machek
2005-02-15 0:54 ` Fix u32 vs. pm_message_t confusion in framebuffers Pavel Machek
2005-02-15 0:55 ` Fix u32 vs. pm_message_t in i8042.c Pavel Machek
2005-02-15 13:10 ` Vojtech Pavlik
2005-02-15 0:57 ` Fix u32 vs. pm_message_t confusion in MMC Pavel Machek
2005-02-15 0:58 ` Fix u32 vs. pm_message_t confusion in serials Pavel Machek
2005-02-15 1:00 ` Fix u32 vs. pm_message_t in macintosh Pavel Machek
2005-02-15 1:00 ` Fix u32 vs. pm_message_t confusion in bttv Pavel Machek
2005-02-15 1:01 ` Fix u32 vs. pm_message_t confusion in AGP Pavel Machek
2005-02-14 21:46 ` PATCH: Address lots of pending pm_message_t changes Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050215221242.GO9231@conscoop.ottawa.on.ca \
--to=scjody@steamballoon.com \
--cc=akpm@osdl.org \
--cc=bcollins@debian.org \
--cc=bernard@blackham.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=ncunningham@cyclades.com \
--cc=pavel@suse.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®