mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [Patch 0/6] Bind Mount Extensions 0.06
@ 2005-02-22 12:09 Herbert Poetzl
  2005-02-23  3:24 ` Matt Mackall
  0 siblings, 1 reply; 5+ messages in thread
From: Herbert Poetzl @ 2005-02-22 12:09 UTC (permalink / raw)
  To: Andrew Morton, Al Viro; +Cc: Linux Kernel ML


Hi Andrew! Al! Folks!

The following set of patches extends the per device 
'noatime', 'nodiratime' and last but not least the 
'ro' (read only) mount option to the vfs --bind mounts, 
allowing them to behave like any other mount, by 
honoring those mount flags (which are silently ignored 
by the current implementation in 2.4.x and 2.6.x)   	

the patch makes the following syscall variations behave 
as expected:

 - open (read/write/trunc), create
 - link, symlink, unlink
 - mknod (reg/block/char/fifo)
 - mkfifo, mkdir, rmdir, rename
 - (f,l)chown, (f)chmod, utime
 - access, truncate, mmap
 - ioctl (gen/ext2/ext3/reiser)
 - (f,l)setxattr, (f,l)removexattr

an older version of this patch was included in 
2.6.0-test6-mm2, and v2.6.4-wolk2.0, the patches were
used by several people, without any issues ...

please consider inclusion (in -mm ?) and/or let me know
what needs to be changed to get this functionality into
mainline ...

patches are against 2.6.11-rc4 but they do apply fine
against 2.6.11-rc4-bk9 (so no modification required)

TIA,
Herbert

(all six patches are)

Signed-off-by: Herbert Pötzl <herbert@13thfloor.at>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Patch 0/6] Bind Mount Extensions 0.06
  2005-02-22 12:09 [Patch 0/6] Bind Mount Extensions 0.06 Herbert Poetzl
@ 2005-02-23  3:24 ` Matt Mackall
  2005-02-23  3:51   ` Andrew Morton
  0 siblings, 1 reply; 5+ messages in thread
From: Matt Mackall @ 2005-02-23  3:24 UTC (permalink / raw)
  To: Andrew Morton, Al Viro, Linux Kernel ML

On Tue, Feb 22, 2005 at 01:09:55PM +0100, Herbert Poetzl wrote:
> 
> Hi Andrew! Al! Folks!
> 
> The following set of patches extends the per device 
> 'noatime', 'nodiratime' and last but not least the 
> 'ro' (read only) mount option to the vfs --bind mounts, 
> allowing them to behave like any other mount, by 
> honoring those mount flags (which are silently ignored 
> by the current implementation in 2.4.x and 2.6.x)   	

Please give each patch a unique, descriptive subject. Summarizing what
each patch is doing in your 0/n so that reviewers can focus on the
bits that are interesting is also helpful.

-- 
Mathematics is the supreme nostalgia of our time.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Patch 0/6] Bind Mount Extensions 0.06
  2005-02-23  3:24 ` Matt Mackall
@ 2005-02-23  3:51   ` Andrew Morton
  2005-02-23  4:06     ` Matt Mackall
  0 siblings, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2005-02-23  3:51 UTC (permalink / raw)
  To: Matt Mackall; +Cc: viro, linux-kernel

Matt Mackall <mpm@selenic.com> wrote:
>
>  Please give each patch a unique, descriptive subject.

yup.

> Summarizing what
>  each patch is doing in your 0/n so that reviewers can focus on the
>  bits that are interesting is also helpful.

Actually, that's fairly irritating, because the 0/n contains useful info
which someone has to go and massage and copy into 1/n.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Patch 0/6] Bind Mount Extensions 0.06
  2005-02-23  3:51   ` Andrew Morton
@ 2005-02-23  4:06     ` Matt Mackall
  2005-02-24 21:04       ` Herbert Poetzl
  0 siblings, 1 reply; 5+ messages in thread
From: Matt Mackall @ 2005-02-23  4:06 UTC (permalink / raw)
  To: Andrew Morton; +Cc: viro, linux-kernel

On Tue, Feb 22, 2005 at 07:51:02PM -0800, Andrew Morton wrote:
> Matt Mackall <mpm@selenic.com> wrote:
> >
> >  Please give each patch a unique, descriptive subject.
> 
> yup.
> 
> > Summarizing what
> >  each patch is doing in your 0/n so that reviewers can focus on the
> >  bits that are interesting is also helpful.
> 
> Actually, that's fairly irritating, because the 0/n contains useful info
> which someone has to go and massage and copy into 1/n.

Certainly, there should be nothing in the summary that isn't already
in the patch itself. What I'm suggesting is more a table of contents:

1/6 move foo to bar so that we can then remove baz
2/6 kill references to baz
...

-- 
Mathematics is the supreme nostalgia of our time.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Patch 0/6] Bind Mount Extensions 0.06
  2005-02-23  4:06     ` Matt Mackall
@ 2005-02-24 21:04       ` Herbert Poetzl
  0 siblings, 0 replies; 5+ messages in thread
From: Herbert Poetzl @ 2005-02-24 21:04 UTC (permalink / raw)
  To: Matt Mackall; +Cc: Andrew Morton, viro, linux-kernel

On Tue, Feb 22, 2005 at 08:06:16PM -0800, Matt Mackall wrote:
> On Tue, Feb 22, 2005 at 07:51:02PM -0800, Andrew Morton wrote:
> > Matt Mackall <mpm@selenic.com> wrote:
> > >
> > >  Please give each patch a unique, descriptive subject.
> > 
> > yup.
> > 
> > > Summarizing what
> > >  each patch is doing in your 0/n so that reviewers can focus on the
> > >  bits that are interesting is also helpful.
> > 
> > Actually, that's fairly irritating, because the 0/n contains useful info
> > which someone has to go and massage and copy into 1/n.
> 
> Certainly, there should be nothing in the summary that isn't already
> in the patch itself. What I'm suggesting is more a table of contents:
> 
> 1/6 move foo to bar so that we can then remove baz
> 2/6 kill references to baz
> ...

well, okay, that is in the comment at the start
of the patch, (because it sometimes is rather lengthy)
but I'll try to add something like a short version to
the subject in the future ...

thanks for the input!
Herbert

> 
> -- 
> Mathematics is the supreme nostalgia of our time.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2005-02-24 21:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-02-22 12:09 [Patch 0/6] Bind Mount Extensions 0.06 Herbert Poetzl
2005-02-23  3:24 ` Matt Mackall
2005-02-23  3:51   ` Andrew Morton
2005-02-23  4:06     ` Matt Mackall
2005-02-24 21:04       ` Herbert Poetzl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®