Re: 2.6.11-rc5-mm1

[Andrew Morton <akpm@osdl.org>]

Russell King <rmk+lkml@arm.linux.org.uk> wrote:
>
> On Tue, Mar 01, 2005 at 10:18:56AM -0500, Valdis.Kletnieks@vt.edu wrote:
> > On Tue, 01 Mar 2005 13:55:29 GMT, Russell King said:
> > > The PCI updates change the prototype of a helper function for 
> > > pci_bus_alloc_resource(), but don't touch the actual helper function
> > > in PCMCIA.
> > 
> > That explains the warning messages that gcc was tossing, which I suspected was
> > involved...
> > 
> > > This means that the PCI update is actually broken - if it's merged as
> > > is into Linus' tree, PCMCIA will break there as well.
> > 
> > Is the patch made to PCI actually incorrect, or is the proper way to do this
> > to propagate the changes into the relevant PCMCIA code?
> 
> PCI has been updated to accept 64-bit resources, but the PCMCIA code 
> has been missed.  So the correct fix is to propagate the changes where
> necessary into the PCMCIA code.

hmm, I missed that.  That's the price of two screenfuls of fscking compile
warnings.

> The minimalist solution is to fix up the PCMCIA alignment functions.

Greg's dropping the 64-bit-resource patch for now.