From: Chris Wright <chrisw@osdl.org>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, jdike@addtoit.com,
ralf@linux-mips.org, schwidefsky@de.ibm.com
Subject: Re: 2.6.11-rc5-mm1
Date: Tue, 1 Mar 2005 13:49:16 -0800 [thread overview]
Message-ID: <20050301214916.GJ28536@shell0.pdx.osdl.net> (raw)
In-Reply-To: <20050301012741.1d791cd2.akpm@osdl.org>
* Andrew Morton (akpm@osdl.org) wrote:
> - I seem to be getting a lot of patches which don't compile if you breathe
> on the .config file, let alone if you try them on another architecture. It
> would be nice to receive less such patches, please.
The ia64 audit bit is likely my fault from the audit header detangle.
I did try w/ and w/out CONFIG_AUDITSYSCALL set, but only on one arch.
I also did a grep, but was only looking at audit_putname/getname, and
missed the others. I just did a more complete grep of the symbols that
can get config'd away (including CONFIG_AUDIT as well), and I think
there's a few more missing pieces. Sorry about that. Jeff, Ralf,
Martin, these look ok?
thanks,
-chris
--
A closer sweep of configurable audit symbols shows the following need
audit.h included when audit.h is detangled from fs.h as in -mm.
arch/um/kernel/ptrace.c for audit_syscall_entry/exit
arch/s390/kernel/ptrace.c for audit_syscall_entry/exit
arch/mips/kernel/ptrace.c for audit_syscall_entry/exit
Signed-off-by: Chris Wright <chrisw@osdl.org>
===== arch/um/kernel/ptrace.c 1.21 vs edited =====
--- 1.21/arch/um/kernel/ptrace.c 2005-01-20 20:59:15 -08:00
+++ edited/arch/um/kernel/ptrace.c 2005-03-01 13:23:06 -08:00
@@ -9,6 +9,7 @@
#include "linux/smp_lock.h"
#include "linux/security.h"
#include "linux/ptrace.h"
+#include "linux/audit.h"
#ifdef CONFIG_PROC_MM
#include "linux/proc_mm.h"
#endif
===== arch/s390/kernel/ptrace.c 1.28 vs edited =====
--- 1.28/arch/s390/kernel/ptrace.c 2005-01-04 18:48:19 -08:00
+++ edited/arch/s390/kernel/ptrace.c 2005-03-01 13:22:45 -08:00
@@ -31,6 +31,7 @@
#include <linux/ptrace.h>
#include <linux/user.h>
#include <linux/security.h>
+#include <linux/audit.h>
#include <asm/segment.h>
#include <asm/page.h>
===== arch/mips/kernel/ptrace.c 1.15 vs edited =====
--- 1.15/arch/mips/kernel/ptrace.c 2005-01-30 22:20:14 -08:00
+++ edited/arch/mips/kernel/ptrace.c 2005-03-01 13:24:48 -08:00
@@ -25,6 +25,7 @@
#include <linux/smp_lock.h>
#include <linux/user.h>
#include <linux/security.h>
+#include <linux/audit.h>
#include <asm/cpu.h>
#include <asm/fpu.h>
next prev parent reply other threads:[~2005-03-01 21:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-01 9:27 2.6.11-rc5-mm1 Andrew Morton
2005-03-01 13:36 ` 2.6.11-rc5-mm1 Valdis.Kletnieks
2005-03-01 13:55 ` 2.6.11-rc5-mm1 Russell King
2005-03-01 15:18 ` 2.6.11-rc5-mm1 Valdis.Kletnieks
2005-03-01 15:27 ` 2.6.11-rc5-mm1 Russell King
2005-03-01 20:42 ` 2.6.11-rc5-mm1 Andrew Morton
2005-03-01 20:45 ` 2.6.11-rc5-mm1 Greg KH
2005-03-01 13:53 ` 2.6.11-rc5-mm1 Mathieu Segaud
2005-03-01 14:00 ` 2.6.11-rc5-mm1 Mathieu Segaud
2005-03-01 14:06 ` 2.6.11-rc5-mm1 Mathieu Segaud
2005-03-01 15:06 ` 2.6.11-rc5-mm1 Edward Shishkin
2005-03-01 15:53 ` 2.6.11-rc5-mm1 (compile stats) John Cherry
2005-03-01 17:40 ` 2.6.11-rc5-mm1 Aurélien Francillon
2005-03-02 8:53 ` 2.6.11-rc5-mm1 Andrew Morton
2005-03-02 15:45 ` 2.6.11-rc5-mm1 Andreas Gruenbacher
2005-03-03 11:01 ` 2.6.11-rc5-mm1 Aurélien Francillon
2005-03-01 20:16 ` 2.6.11-rc5-mm1 Adrian Bunk
2005-03-01 21:58 ` 2.6.11-rc5-mm1 Andrew Morton
2005-03-01 21:49 ` Chris Wright [this message]
2005-03-01 22:08 ` 2.6.11-rc5-mm1 Andrew Morton
2005-03-03 8:04 ` 2.6.11-rc5-mm1 Jeff Dike
2005-03-03 16:21 ` 2.6.11-rc5-mm1 Chris Wright
2005-03-03 19:25 ` 2.6.11-rc5-mm1 Jeff Dike
2005-03-03 19:14 ` 2.6.11-rc5-mm1 Chris Wright
2005-03-04 11:01 ` 2.6.11-rc5-mm1 zwx
2005-03-01 23:43 ` [2.6.11-rc5-mm1 patch] reiser4 Kconfig help cleanup Adrian Bunk
2005-03-02 9:01 ` Jes Sorensen
2005-03-02 9:14 ` Andrew Morton
2005-03-02 14:29 ` Nikita Danilov
2005-03-02 14:40 ` [2.6.11-rc5-mm1 patch] reiser4 cleanup (PG_arch_1) Vladimir Saveliev
2005-03-03 13:17 ` [2.6.11-rc5-mm1 patch] fs/reiser4/: possible cleanups Adrian Bunk
2005-03-03 13:22 ` [2.6.11-rc5-mm1 patch] drivers/acpi/pcc_acpi.c: section fixes Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050301214916.GJ28536@shell0.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=akpm@osdl.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome