From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Jesper Juhl <juhl-lkml@dif.dk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero
Date: Fri, 15 Apr 2005 09:21:50 +0100 [thread overview]
Message-ID: <20050415082150.GA19095@infradead.org> (raw)
In-Reply-To: <20050415013100.GY8669@parcelfarce.linux.theplanet.co.uk>
On Fri, Apr 15, 2005 at 02:31:00AM +0100, Matthew Wilcox wrote:
> On Fri, Apr 15, 2005 at 03:07:42AM +0200, Jesper Juhl wrote:
> > 'arg' is unsigned so it can never be less than zero, so testing for that
> > is pointless and also generates a warning when building with gcc -W. This
> > patch eliminates the pointless check.
>
> Didn't Linus already reject this one 6 months ago?
I think Linux only complained if we're using some typedef that actually
may be signed. For fcntl that 'arg' argument is unsigned and that's hardcoded
in the ABI. So the check doesn't make sense at all.
next prev parent reply other threads:[~2005-04-15 8:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-15 1:07 Jesper Juhl
2005-04-15 1:31 ` Matthew Wilcox
2005-04-15 8:21 ` Christoph Hellwig [this message]
2005-04-15 11:29 ` Matthew Wilcox
2005-04-15 11:32 ` Christoph Hellwig
2005-04-15 12:03 ` Herbert Xu
2005-04-15 13:21 ` Matthew Wilcox
2005-04-17 21:00 ` Jesper Juhl
2005-04-15 8:23 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050415082150.GA19095@infradead.org \
--to=hch@infradead.org \
--cc=juhl-lkml@dif.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®