From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Christoph Hellwig <hch@infradead.org>,
Jesper Juhl <juhl-lkml@dif.dk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero
Date: Fri, 15 Apr 2005 12:32:18 +0100 [thread overview]
Message-ID: <20050415113218.GA22528@infradead.org> (raw)
In-Reply-To: <20050415112908.GZ8669@parcelfarce.linux.theplanet.co.uk>
On Fri, Apr 15, 2005 at 12:29:08PM +0100, Matthew Wilcox wrote:
> > I think Linux only complained if we're using some typedef that actually
> > may be signed. For fcntl that 'arg' argument is unsigned and that's hardcoded
> > in the ABI. So the check doesn't make sense at all.
>
> No, it was exactly this patch:
> http://www.ussg.iu.edu/hypermail/linux/kernel/0401.0/1816.html
Hmm. Looks I absolutely disagree with Linus on this one ;-)
next prev parent reply other threads:[~2005-04-15 11:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-15 1:07 Jesper Juhl
2005-04-15 1:31 ` Matthew Wilcox
2005-04-15 8:21 ` Christoph Hellwig
2005-04-15 11:29 ` Matthew Wilcox
2005-04-15 11:32 ` Christoph Hellwig [this message]
2005-04-15 12:03 ` Herbert Xu
2005-04-15 13:21 ` Matthew Wilcox
2005-04-17 21:00 ` Jesper Juhl
2005-04-15 8:23 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050415113218.GA22528@infradead.org \
--to=hch@infradead.org \
--cc=juhl-lkml@dif.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®