From: Matthew Wilcox <matthew@wil.cx>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: Matthew Wilcox <matthew@wil.cx>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero
Date: Fri, 15 Apr 2005 02:31:00 +0100 [thread overview]
Message-ID: <20050415013100.GY8669@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.62.0504150303480.3466@dragon.hyggekrogen.localhost>
On Fri, Apr 15, 2005 at 03:07:42AM +0200, Jesper Juhl wrote:
> 'arg' is unsigned so it can never be less than zero, so testing for that
> is pointless and also generates a warning when building with gcc -W. This
> patch eliminates the pointless check.
Didn't Linus already reject this one 6 months ago?
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
next prev parent reply other threads:[~2005-04-15 1:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-15 1:07 Jesper Juhl
2005-04-15 1:31 ` Matthew Wilcox [this message]
2005-04-15 8:21 ` Christoph Hellwig
2005-04-15 11:29 ` Matthew Wilcox
2005-04-15 11:32 ` Christoph Hellwig
2005-04-15 12:03 ` Herbert Xu
2005-04-15 13:21 ` Matthew Wilcox
2005-04-17 21:00 ` Jesper Juhl
2005-04-15 8:23 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050415013100.GY8669@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=juhl-lkml@dif.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®