* 2.4.30 xfs bug
@ 2005-05-12 18:17 Russell Miller
2005-05-18 14:09 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Russell Miller @ 2005-05-12 18:17 UTC (permalink / raw)
To: linux-kernel
2.4.30 will not compile if XFS is turned on, but XFS debugging is not.
Culprit is:
fs/xfs/linux-2.4/xfs_buf.c line 1076. Apparently pagebuf_lock_value is used
somewhere else, even if it's not defined because debugging is off.
--Russell
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 2.4.30 xfs bug
2005-05-12 18:17 2.4.30 xfs bug Russell Miller
@ 2005-05-18 14:09 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2005-05-18 14:09 UTC (permalink / raw)
To: Russell Miller, marcelo.tosatti; +Cc: linux-kernel
On Thu, May 12, 2005 at 11:17:01AM -0700, Russell Miller wrote:
> 2.4.30 will not compile if XFS is turned on, but XFS debugging is not.
> Culprit is:
>
> fs/xfs/linux-2.4/xfs_buf.c line 1076. Apparently pagebuf_lock_value is used
> somewhere else, even if it's not defined because debugging is off.
Looks like a trivial one-liner got lost when merging from the SGI CVS tree.
Macelo, can you apply this little patch below?
--- 1.195/fs/xfs/linux-2.4/xfs_buf.c 2005-01-12 01:08:23 +01:00
+++ edited/fs/xfs/linux-2.4/xfs_buf.c 2005-05-18 16:06:09 +02:00
@@ -1073,7 +1073,7 @@ pagebuf_cond_lock( /* lock buffer, if
return(locked ? 0 : -EBUSY);
}
-#ifdef DEBUG
+#if defined(DEBUG) || defined(XFS_BLI_TRACE)
/*
* pagebuf_lock_value
*
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-05-18 14:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-05-12 18:17 2.4.30 xfs bug Russell Miller
2005-05-18 14:09 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®