mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Fix NUMA node sizing in nr_free_zone_pages
@ 2005-07-29 18:31 Martin J. Bligh
  2005-07-29 20:05 ` Andrew Morton
  2005-07-30  5:40 ` Andrew Morton
  0 siblings, 2 replies; 4+ messages in thread
From: Martin J. Bligh @ 2005-07-29 18:31 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, colpatch

We are iterating over all nodes in nr_free_zone_pages(). Because the 
fallback zonelists contain all nodes in the system, and we walk all
the zonelists, we're counting memory multiple times (once for each
node). This caused us to make a size estimate of 32GB for an 8GB
AMD64 box, which makes all the dirty ratio calculations, etc incorrect.

There's still a further bug to fix from e820 holes causing overestimation
as well, but this fix is separate, and good as is, and fixes one class
of problems. Problem found by Badari, and tested by Ram Pai - thanks!

Signed-off-by:  Martin J. Bligh <mbligh@mbligh.org> 
Signed-off-by:  Matt Dobson <colpatch@us.ibm.com>

diff -purN -X /home/mbligh/.diff.exclude linux-2.6.12/mm/page_alloc.c 2.6.12-nr_free_zone_pages/mm/page_alloc.c
--- linux-2.6.12/mm/page_alloc.c	2005-06-17 17:21:43.000000000 -0700
+++ 2.6.12-nr_free_zone_pages/mm/page_alloc.c	2005-07-28 16:54:03.000000000 -0700
@@ -1006,20 +1006,19 @@ unsigned int nr_free_pages_pgdat(pg_data
 
 static unsigned int nr_free_zone_pages(int offset)
 {
-	pg_data_t *pgdat;
+	/* Just pick one node, since fallback list is circular */
+	pg_data_t *pgdat = NODE_DATA(numa_node_id());
 	unsigned int sum = 0;
 
-	for_each_pgdat(pgdat) {
-		struct zonelist *zonelist = pgdat->node_zonelists + offset;
-		struct zone **zonep = zonelist->zones;
-		struct zone *zone;
+	struct zonelist *zonelist = pgdat->node_zonelists + offset;
+	struct zone **zonep = zonelist->zones;
+	struct zone *zone;
 
-		for (zone = *zonep++; zone; zone = *zonep++) {
-			unsigned long size = zone->present_pages;
-			unsigned long high = zone->pages_high;
-			if (size > high)
-				sum += size - high;
-		}
+	for (zone = *zonep++; zone; zone = *zonep++) {
+		unsigned long size = zone->present_pages;
+		unsigned long high = zone->pages_high;
+		if (size > high)
+			sum += size - high;
 	}
 
 	return sum;



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2005-07-30 13:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-07-29 18:31 [PATCH] Fix NUMA node sizing in nr_free_zone_pages Martin J. Bligh
2005-07-29 20:05 ` Andrew Morton
2005-07-30  5:40 ` Andrew Morton
2005-07-30 13:49   ` Martin J. Bligh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome