From: Andi Kleen <ak@suse.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andi Kleen <ak@suse.de>, LKML <linux-kernel@vger.kernel.org>,
rmk@arm.linux.org.uk, gerg@uclinux.org, jdike@karaya.com,
sammy@sammy.net, lethal@linux-sh.org, wli@holomorphy.com,
davem@davemloft.net, matthew@wil.cx, geert@linux-m68k.org,
paulus@samba.org, davej@codemonkey.org.uk, tony.luck@intel.com,
dev-etrax@axis.com, rpurdie@rpsys.net, spyro@f2s.com,
Robert Wilkens <robw@optonline.net>,
Bodo Stroesser <bstroesser@fujitsu-siemens.com>,
Jan Engelhardt <jengelh@linux01.gwdg.de>,
Chris Wright <chrisw@osdl.org>, Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] Convert sigaction to act like other unices
Date: Sat, 13 Aug 2005 23:29:24 +0200 [thread overview]
Message-ID: <20050813212924.GQ22901@wotan.suse.de> (raw)
In-Reply-To: <1123941614.5296.112.camel@localhost.localdomain>
On Sat, Aug 13, 2005 at 10:00:14AM -0400, Steven Rostedt wrote:
> On Sat, 2005-08-13 at 14:39 +0200, Andi Kleen wrote:
> > On Fri, Aug 12, 2005 at 10:40:02PM -0400, Steven Rostedt wroqte:
> > > Here's a patch that converts all architectures to behave like other unix
> > > boxes signal handling. It's funny that I didn't need to change the m68k
> > > architecture, since it was the only one that already behaves this way!
> > > (the m68knommu does not!)
> >
> > <rest snipped which also wasn't better>
> >
> > This is not a description of what you changed. A patch entry has to
> > start with a rationale and then a description of the change.
>
> Sorry, I forgot that not all were in on the thread. (duh, I added a
> bunch of others, I guess I wasn't thinking clearly).
I actually read the thread, but patches with useless descriptions
like your previous one cannot be applied in general because you cannot expect
that people later looking at the <VCS system of the week> logs
know about some obscure thread months or years before. Or rather
the person who applied it would need to write a better description
on his own, which is not their job.
My general feeling about the change is that it risks breaking programs
and doesn't seem to have any compelling advantages,
so unless there is a bug demonstrated I wouldn't apply it.
-Andi
next prev parent reply other threads:[~2005-08-13 21:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-13 2:40 Steven Rostedt
2005-08-13 12:39 ` Andi Kleen
2005-08-13 14:00 ` Steven Rostedt
2005-08-13 21:29 ` Andi Kleen [this message]
2005-08-14 12:20 ` Jesper Juhl
2005-08-16 17:04 ` Steven Rostedt
2005-08-16 17:15 ` Linus Torvalds
2005-08-13 14:25 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050813212924.GQ22901@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=bstroesser@fujitsu-siemens.com \
--cc=chrisw@osdl.org \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=dev-etrax@axis.com \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=jdike@karaya.com \
--cc=jengelh@linux01.gwdg.de \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=paulus@samba.org \
--cc=rmk@arm.linux.org.uk \
--cc=robw@optonline.net \
--cc=rostedt@goodmis.org \
--cc=rpurdie@rpsys.net \
--cc=sammy@sammy.net \
--cc=spyro@f2s.com \
--cc=tony.luck@intel.com \
--cc=torvalds@osdl.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome