* [PATCH] configurable debug info from radeonfb old driver
@ 2005-08-13 22:18 Michael Iatrou
2005-08-14 8:25 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Michael Iatrou @ 2005-08-13 22:18 UTC (permalink / raw)
To: linux-kernel; +Cc: ajoshi, akpm
Hi,
Currently, radeonfb old driver always prints debugging informations. This
patch makes debug info reporting configurable.
diff -urN linux-2.6.13-rc6/drivers/video/Kconfig linux-2.6.13-rc6.new/drivers/video/Kconfig
--- linux-2.6.13-rc6/drivers/video/Kconfig 2005-08-14 00:48:34.000000000 +0300
+++ linux-2.6.13-rc6.new/drivers/video/Kconfig 2005-08-14 00:54:10.000000000 +0300
@@ -936,6 +936,15 @@
There is a product page at
<http://www.ati.com/na/pages/products/pc/radeon32/index.html>.
+config FB_RADEON_OLD_DEBUG
+ bool "Enable debug output from Old Radeon driver"
+ depends on FB_RADEON_OLD
+ default n
+ help
+ Say Y here if you want the Radeon driver to output all sorts
+ of debugging informations to provide to the maintainer when
+ something goes wrong.
+
config FB_RADEON
tristate "ATI Radeon display support"
depends on FB && PCI
diff -urN linux-2.6.13-rc6/drivers/video/radeonfb.c linux-2.6.13-rc6.new/drivers/video/radeonfb.c
--- linux-2.6.13-rc6/drivers/video/radeonfb.c 2005-06-19 14:49:29.000000000 +0300
+++ linux-2.6.13-rc6.new/drivers/video/radeonfb.c 2005-08-14 00:55:16.000000000 +0300
@@ -80,7 +80,11 @@
#include <video/radeon.h>
#include <linux/radeonfb.h>
-#define DEBUG 1
+#ifdef CONFIG_FB_RADEON_OLD_DEBUG
+#define DEBUG 1
+#else
+#define DEBUG 0
+#endif
#if DEBUG
#define RTRACE printk
--
Michael Iatrou
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] configurable debug info from radeonfb old driver
2005-08-13 22:18 [PATCH] configurable debug info from radeonfb old driver Michael Iatrou
@ 2005-08-14 8:25 ` Andrew Morton
2005-08-14 10:01 ` Michael Iatrou
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2005-08-14 8:25 UTC (permalink / raw)
To: Michael Iatrou; +Cc: linux-kernel, ajoshi
Michael Iatrou <m.iatrou@freemail.gr> wrote:
>
> Hi,
>
> Currently, radeonfb old driver always prints debugging informations. This
> patch makes debug info reporting configurable.
>
>
> diff -urN linux-2.6.13-rc6/drivers/video/Kconfig linux-2.6.13-rc6.new/drivers/video/Kconfig
> --- linux-2.6.13-rc6/drivers/video/Kconfig 2005-08-14 00:48:34.000000000 +0300
> +++ linux-2.6.13-rc6.new/drivers/video/Kconfig 2005-08-14 00:54:10.000000000 +0300
> @@ -936,6 +936,15 @@
> There is a product page at
> <http://www.ati.com/na/pages/products/pc/radeon32/index.html>.
>
> +config FB_RADEON_OLD_DEBUG
> + bool "Enable debug output from Old Radeon driver"
> + depends on FB_RADEON_OLD
> + default n
> + help
> + Say Y here if you want the Radeon driver to output all sorts
> + of debugging informations to provide to the maintainer when
> + something goes wrong.
> +
> config FB_RADEON
> tristate "ATI Radeon display support"
> depends on FB && PCI
> diff -urN linux-2.6.13-rc6/drivers/video/radeonfb.c linux-2.6.13-rc6.new/drivers/video/radeonfb.c
> --- linux-2.6.13-rc6/drivers/video/radeonfb.c 2005-06-19 14:49:29.000000000 +0300
> +++ linux-2.6.13-rc6.new/drivers/video/radeonfb.c 2005-08-14 00:55:16.000000000 +0300
> @@ -80,7 +80,11 @@
> #include <video/radeon.h>
> #include <linux/radeonfb.h>
>
> -#define DEBUG 1
> +#ifdef CONFIG_FB_RADEON_OLD_DEBUG
> +#define DEBUG 1
> +#else
> +#define DEBUG 0
> +#endif
>
> #if DEBUG
> #define RTRACE printk
That's probably a bit fancier than we really need. How about we just set
DEBUG to zero?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] configurable debug info from radeonfb old driver
2005-08-14 8:25 ` Andrew Morton
@ 2005-08-14 10:01 ` Michael Iatrou
0 siblings, 0 replies; 3+ messages in thread
From: Michael Iatrou @ 2005-08-14 10:01 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, ajoshi
When the date was Sunday 14 August 2005 11:25, Andrew Morton wrote:
> Michael Iatrou <m.iatrou@freemail.gr> wrote:
> >
> > Hi,
> >
> > Currently, radeonfb old driver always prints debugging informations. This
> > patch makes debug info reporting configurable.
> >
> >
> > diff -urN linux-2.6.13-rc6/drivers/video/Kconfig linux-2.6.13-rc6.new/drivers/video/Kconfig
> > --- linux-2.6.13-rc6/drivers/video/Kconfig 2005-08-14 00:48:34.000000000 +0300
> > +++ linux-2.6.13-rc6.new/drivers/video/Kconfig 2005-08-14 00:54:10.000000000 +0300
> > @@ -936,6 +936,15 @@
> > There is a product page at
> > <http://www.ati.com/na/pages/products/pc/radeon32/index.html>.
> >
> > +config FB_RADEON_OLD_DEBUG
> > + bool "Enable debug output from Old Radeon driver"
> > + depends on FB_RADEON_OLD
> > + default n
> > + help
> > + Say Y here if you want the Radeon driver to output all sorts
> > + of debugging informations to provide to the maintainer when
> > + something goes wrong.
> > +
> > config FB_RADEON
> > tristate "ATI Radeon display support"
> > depends on FB && PCI
> > diff -urN linux-2.6.13-rc6/drivers/video/radeonfb.c linux-2.6.13-rc6.new/drivers/video/radeonfb.c
> > --- linux-2.6.13-rc6/drivers/video/radeonfb.c 2005-06-19 14:49:29.000000000 +0300
> > +++ linux-2.6.13-rc6.new/drivers/video/radeonfb.c 2005-08-14 00:55:16.000000000 +0300
> > @@ -80,7 +80,11 @@
> > #include <video/radeon.h>
> > #include <linux/radeonfb.h>
> >
> > -#define DEBUG 1
> > +#ifdef CONFIG_FB_RADEON_OLD_DEBUG
> > +#define DEBUG 1
> > +#else
> > +#define DEBUG 0
> > +#endif
> >
> > #if DEBUG
> > #define RTRACE printk
>
> That's probably a bit fancier than we really need. How about we just set
> DEBUG to zero?
That's an option too.
diff -urN linux-2.6.13-rc6/drivers/video/radeonfb.c linux-2.6.13-rc6.new/drivers/video/radeonfb.c
--- linux-2.6.13-rc6/drivers/video/radeonfb.c 2005-06-19 14:49:29.000000000 +0300
+++ linux-2.6.13-rc6.new/drivers/video/radeonfb.c 2005-08-14 12:58:10.000000000 +0300
@@ -80,7 +80,7 @@
#include <video/radeon.h>
#include <linux/radeonfb.h>
-#define DEBUG 1
+#define DEBUG 0
#if DEBUG
#define RTRACE printk
--
Michael Iatrou
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-08-14 10:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-08-13 22:18 [PATCH] configurable debug info from radeonfb old driver Michael Iatrou
2005-08-14 8:25 ` Andrew Morton
2005-08-14 10:01 ` Michael Iatrou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®