From: Andrew Morton <akpm@osdl.org>
To: Anton Altaparmakov <aia21@cam.ac.uk>
Cc: glommer@br.ibm.com, mikulas@artax.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
ext2-devel@lists.sourceforge.net, hirofumi@mail.parknet.co.jp,
linux-ntfs-dev@lists.sourceforge.net, aia21@cantab.net,
hch@infradead.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH] Use of getblk differs between locations
Date: Mon, 10 Oct 2005 16:36:48 -0700 [thread overview]
Message-ID: <20051010163648.3e305b63.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0510102328110.6247@hermes-1.csi.cam.ac.uk>
Anton Altaparmakov <aia21@cam.ac.uk> wrote:
>
> > Maybe the best solution is neither one nor another. Testing and failing
> > gracefully seems better.
> >
> > What do you think?
>
> I certainly agree with you there. I neither want a deadlock nor
> corruption. (-:
Yup. In the present implementation __getblk_slow() "cannot fail". It's
conceivable that at some future stage we'll change __getblk_slow() so that
it returns NULL on an out-of-memory condition. Anyone making such a change
would have to audit all callers to make sure that they handle the NULL
correctly.
It is appropriate at this time to fix the callers so that they correctly
handle the NULL return. However, it is non-trivial to actually _test_ such
changes, and such changes should be tested. Or at least, they should be
done with considerable care and knowledge of the specific filesystems.
next prev parent reply other threads:[~2005-10-10 23:37 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-10 20:45 Glauber de Oliveira Costa
2005-10-10 21:20 ` Anton Altaparmakov
2005-10-10 21:46 ` Glauber de Oliveira Costa
2005-10-10 21:58 ` Mikulas Patocka
2005-10-10 22:25 ` Anton Altaparmakov
2005-10-10 22:49 ` Mikulas Patocka
2005-10-10 23:12 ` Glauber de Oliveira Costa
2005-10-10 23:16 ` Mikulas Patocka
2005-10-10 23:33 ` Glauber de Oliveira Costa
2005-10-10 23:34 ` Mikulas Patocka
2005-10-10 23:49 ` Glauber de Oliveira Costa
2005-10-11 7:52 ` Anton Altaparmakov
2005-10-12 19:51 ` Jeff Mahoney
2005-10-12 19:59 ` Mikulas Patocka
2005-10-12 20:07 ` Jeff Mahoney
2005-10-12 20:12 ` Mikulas Patocka
2005-10-12 20:14 ` Anton Altaparmakov
2005-10-12 20:31 ` Mikulas Patocka
2005-10-12 21:19 ` Jeff Mahoney
2005-10-12 21:35 ` Anton Altaparmakov
2005-10-13 0:09 ` Jamie Lokier
2005-10-13 0:21 ` Mikulas Patocka
2005-10-13 0:27 ` Jamie Lokier
2005-10-13 11:17 ` Pavel Machek
2005-10-14 16:52 ` Jamie Lokier
2005-10-14 18:26 ` Mikulas Patocka
2005-10-13 0:05 ` Jamie Lokier
2005-10-12 20:08 ` Anton Altaparmakov
2005-10-10 22:36 ` Glauber de Oliveira Costa
2005-10-10 22:28 ` Anton Altaparmakov
2005-10-10 23:36 ` Andrew Morton [this message]
2005-10-11 0:07 ` Glauber de Oliveira Costa
2005-10-11 0:05 ` Al Viro
2005-10-11 0:40 ` Glauber de Oliveira Costa
2005-10-11 12:35 ` Jan Hudec
2005-10-11 0:09 ` Mikulas Patocka
2005-10-11 1:07 ` Andrew Morton
2005-10-11 1:20 ` Mikulas Patocka
2005-10-11 5:02 ` Andrew Morton
2005-10-11 8:07 ` Anton Altaparmakov
2005-10-11 8:01 ` Anton Altaparmakov
2005-10-13 0:58 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051010163648.3e305b63.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=aia21@cam.ac.uk \
--cc=aia21@cantab.net \
--cc=ext2-devel@lists.sourceforge.net \
--cc=glommer@br.ibm.com \
--cc=hch@infradead.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome