From: Andrew Morton <akpm@osdl.org>
To: cplk@itee.uq.edu.au, Neil Brown <neilb@cse.unsw.edu.au>
Cc: bunk@stusta.de, heiko.carstens@de.ibm.com,
linux-kernel@vger.kernel.org, aherrman@de.ibm.com,
dm-devel@redhat.com
Subject: Re: [PATCH resubmit] do_mount: reduce stack consumption
Date: Fri, 4 Nov 2005 17:37:21 -0800 [thread overview]
Message-ID: <20051104173721.597bd223.akpm@osdl.org> (raw)
In-Reply-To: <Pine.GSO.4.60.0511051108070.2449@mango.itee.uq.edu.au>
cplk@itee.uq.edu.au wrote:
>
> > > > This part of the call trace is actually good for >1500 bytes of stack
> > > > usage and is what kills us and should be fixed.
> > > > I'm surprised that there are no other bug reports regarding DM and
> > > > stack overflow with 4k stacks.
> > > >...
> > >
> > > There were some reports of dm+xfs overflows with 4k stacks on i386.
> > >
> > > The xfs side was sorted out, but I son't know the state of the dm part.
> > >
> >
> > The state is Very Bad, IMO. At the very least, DM should struggle to the
> > utmost to reduce the stack utilisation around that recursion point.
>
> Neil Brown suggested a change to generic_make_request to convert recursion
> through it into iteration (see http://lkml.org/lkml/2005/9/2/34 ), but
> there was no discussion at the time. Would this help with this case?
It certainly would. That looks like a good thing to do some more work on.
next prev parent reply other threads:[~2005-11-05 1:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 10:50 Heiko Carstens
2005-11-04 11:48 ` Al Viro
2005-11-04 12:57 ` Heiko Carstens
2005-11-04 14:06 ` Al Viro
2005-11-04 22:03 ` Heiko Carstens
2005-11-04 16:48 ` Andrew Morton
2005-11-04 21:27 ` Heiko Carstens
2005-11-04 23:55 ` Adrian Bunk
2005-11-05 0:08 ` Andrew Morton
2005-11-05 1:15 ` cplk
2005-11-05 1:37 ` Andrew Morton [this message]
2005-11-05 5:37 ` Neil Brown
2005-11-07 0:16 ` [dm-devel] " Neil Brown
2005-11-07 16:15 ` Heiko Carstens
2005-11-07 22:12 ` Neil Brown
2005-11-07 23:37 ` Andrew Morton
2005-11-08 0:32 ` Nick Piggin
2005-11-08 1:03 ` Neil Brown
2005-11-08 1:15 ` Andrew Morton
2005-11-08 1:37 ` Nick Piggin
2005-11-04 15:53 Andreas Herrmann
2005-11-04 17:42 ` Andrew Morton
2005-11-04 17:45 ` Arjan van de Ven
2005-11-04 18:37 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051104173721.597bd223.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=aherrman@de.ibm.com \
--cc=bunk@stusta.de \
--cc=cplk@itee.uq.edu.au \
--cc=dm-devel@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®