From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Neil Brown <neilb@suse.de>
Cc: device-mapper development <dm-devel@redhat.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, aherrman@de.ibm.com,
bunk@stusta.de, cplk@itee.uq.edu.au
Subject: Re: [dm-devel] Re: [PATCH resubmit] do_mount: reduce stack consumption
Date: Mon, 7 Nov 2005 17:15:22 +0100 [thread overview]
Message-ID: <20051107161522.GA28164@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <17262.40176.342746.634262@cse.unsw.edu.au>
> > Ok, I'll dust it off, make sure it seems to work (at the time I first
> > wrote it, I think it caused 'md' to deadlock) and submit it.
> >
> > NeilBrown
> >
>
> For your consideration and testing (it works for me, but I'd like to
> see it tested a bit more heavily in a variety of configurations).
Works fine for me. Thank you!
However I noticed another recursive call while dumping all call traces:
...
[<00000000001e1952>] zfcp_scsi_command_async+0xf6/0x1c4
[<000000000013cd6a>] scsi_dispatch_cmd+0x1ae/0x37c
[<0000000000143dc4>] scsi_request_fn+0x1dc/0x390
[<000000000012f65a>] generic_unplug_device+0x2a/0x38
[<0000000000181262>] dm_table_unplug_all+0x42/0x58
[<000000000017e598>] dm_unplug_all+0x2c/0x44
[<0000000000181262>] dm_table_unplug_all+0x42/0x58
[<000000000017e598>] dm_unplug_all+0x2c/0x44
[<00000000000782aa>] block_sync_page+0x4e/0x68
[<00000000000514f8>] sync_page+0x48/0x68
[<00000000002ab36e>] __wait_on_bit+0x9a/0xe0
...
Even though there is a lot of space left on the stack (this time) I don't
think it's desirable to have recursive calls. Especially not when going
for 4k stacks.
Heiko
next prev parent reply other threads:[~2005-11-07 16:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 10:50 Heiko Carstens
2005-11-04 11:48 ` Al Viro
2005-11-04 12:57 ` Heiko Carstens
2005-11-04 14:06 ` Al Viro
2005-11-04 22:03 ` Heiko Carstens
2005-11-04 16:48 ` Andrew Morton
2005-11-04 21:27 ` Heiko Carstens
2005-11-04 23:55 ` Adrian Bunk
2005-11-05 0:08 ` Andrew Morton
2005-11-05 1:15 ` cplk
2005-11-05 1:37 ` Andrew Morton
2005-11-05 5:37 ` Neil Brown
2005-11-07 0:16 ` [dm-devel] " Neil Brown
2005-11-07 16:15 ` Heiko Carstens [this message]
2005-11-07 22:12 ` Neil Brown
2005-11-07 23:37 ` Andrew Morton
2005-11-08 0:32 ` Nick Piggin
2005-11-08 1:03 ` Neil Brown
2005-11-08 1:15 ` Andrew Morton
2005-11-08 1:37 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051107161522.GA28164@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=aherrman@de.ibm.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=cplk@itee.uq.edu.au \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®