From: Andrew Morton <akpm@osdl.org>
To: Neil Brown <neilb@suse.de>
Cc: dm-devel@redhat.com, heiko.carstens@de.ibm.com,
linux-kernel@vger.kernel.org, aherrman@de.ibm.com,
bunk@stusta.de, cplk@itee.uq.edu.au
Subject: Re: [dm-devel] Re: [PATCH resubmit] do_mount: reduce stack consumption
Date: Mon, 7 Nov 2005 15:37:06 -0800 [thread overview]
Message-ID: <20051107153706.2f3c8b67.akpm@osdl.org> (raw)
In-Reply-To: <17262.40176.342746.634262@cse.unsw.edu.au>
Neil Brown <neilb@suse.de> wrote:
>
> ...
> Reduce stack usage with stacked block devices
>
> ...
> diff ./include/linux/sched.h~current~ ./include/linux/sched.h
> --- ./include/linux/sched.h~current~ 2005-11-07 10:01:36.000000000 +1100
> +++ ./include/linux/sched.h 2005-11-07 10:02:23.000000000 +1100
> @@ -829,6 +829,9 @@ struct task_struct {
> /* journalling filesystem info */
> void *journal_info;
>
> +/* stacked block device info */
> + struct bio *bio_list, **bio_tail;
> +
> /* VM state */
> struct reclaim_state *reclaim_state;
>
More state in the task_strut is a bit sad, but not nearly as sad as deep
recursion in our deepest codepath..
Possibly one could do:
struct make_request_state {
struct bio *bio_list;
struct bio **bio_tail;
};
and stick a `struct make_request_state *' into the task_struct and actually
allocate the thing on the stack. That's not much nicer though.
next prev parent reply other threads:[~2005-11-07 23:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 10:50 Heiko Carstens
2005-11-04 11:48 ` Al Viro
2005-11-04 12:57 ` Heiko Carstens
2005-11-04 14:06 ` Al Viro
2005-11-04 22:03 ` Heiko Carstens
2005-11-04 16:48 ` Andrew Morton
2005-11-04 21:27 ` Heiko Carstens
2005-11-04 23:55 ` Adrian Bunk
2005-11-05 0:08 ` Andrew Morton
2005-11-05 1:15 ` cplk
2005-11-05 1:37 ` Andrew Morton
2005-11-05 5:37 ` Neil Brown
2005-11-07 0:16 ` [dm-devel] " Neil Brown
2005-11-07 16:15 ` Heiko Carstens
2005-11-07 22:12 ` Neil Brown
2005-11-07 23:37 ` Andrew Morton [this message]
2005-11-08 0:32 ` Nick Piggin
2005-11-08 1:03 ` Neil Brown
2005-11-08 1:15 ` Andrew Morton
2005-11-08 1:37 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051107153706.2f3c8b67.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=aherrman@de.ibm.com \
--cc=bunk@stusta.de \
--cc=cplk@itee.uq.edu.au \
--cc=dm-devel@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®