From: "David S. Miller" <davem@davemloft.net>
To: hugh@veritas.com
Cc: akpm@osdl.org, nickpiggin@yahoo.com.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/11] unpaged: get_user_pages VM_RESERVED
Date: Thu, 17 Nov 2005 15:29:00 -0800 (PST) [thread overview]
Message-ID: <20051117.152900.72981605.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.61.0511171928320.4563@goblin.wat.veritas.com>
From: Hugh Dickins <hugh@veritas.com>
Date: Thu, 17 Nov 2005 19:29:17 +0000 (GMT)
> The PageReserved removal in 2.6.15-rc1 prohibited get_user_pages on the
> areas flagged VM_RESERVED in place of PageReserved. That is correct in
> theory - we ought not to interfere with struct pages in such a reserved
> area; but in practice it broke BTTV for one.
>
> So revert to prohibiting only on VM_IO: if someone gets into trouble
> with get_user_pages on VM_RESERVED, it'll just be a "don't do that".
>
> You can argue that videobuf_mmap_mapper shouldn't set VM_RESERVED in the
> first place, but now's not the time for breaking drivers without notice.
>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
It might be a nice little 2.6.16 project to simplify that
videobuf_mmap_mapper() code, and in fact other driver subsystems want
a similar facility, such as DVB.
So putting some helper routines in the core MM for this, in one spot,
seems like the long term way to handle this peculiar stuff.
next prev parent reply other threads:[~2005-11-17 23:29 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-17 19:28 [PATCH 00/11] unpaged: PageReserved VM fixups Hugh Dickins
2005-11-17 19:29 ` [PATCH 01/11] unpaged: get_user_pages VM_RESERVED Hugh Dickins
2005-11-17 23:29 ` David S. Miller [this message]
2005-11-17 19:30 ` [PATCH 02/11] unpaged: private write VM_RESERVED Hugh Dickins
2005-11-17 19:41 ` Dave Jones
2005-11-17 20:46 ` Dominik Brodowski
2005-11-17 20:51 ` Dave Jones
2005-11-17 23:58 ` David S. Miller
2005-11-18 7:12 ` Dominik Brodowski
2005-11-18 7:59 ` David S. Miller
2005-11-17 20:59 ` Dominik Brodowski
2005-11-17 23:36 ` David S. Miller
2005-11-17 19:31 ` [PATCH 03/11] unpaged: sound nopage get_page Hugh Dickins
2005-11-17 23:41 ` David S. Miller
2005-11-17 19:32 ` [PATCH 04/11] unpaged: unifdefed PageCompound Hugh Dickins
2005-11-17 23:43 ` David S. Miller
2005-11-19 20:15 ` Hugh Dickins
2005-11-19 20:55 ` William Lee Irwin III
2005-11-19 21:41 ` David S. Miller
2005-11-19 21:58 ` William Lee Irwin III
2005-11-17 19:34 ` [PATCH 05/11] unpaged: VM_UNPAGED Hugh Dickins
2005-11-17 20:59 ` William Lee Irwin III
2005-11-17 23:46 ` David S. Miller
2005-11-17 19:36 ` [PATCH 06/11] unpaged: VM_NONLINEAR VM_RESERVED Hugh Dickins
2005-11-17 19:37 ` [PATCH 07/11] unpaged: COW on VM_UNPAGED Hugh Dickins
2005-11-17 23:52 ` David S. Miller
2005-11-18 5:46 ` Nick Piggin
2005-11-18 6:45 ` David S. Miller
2005-11-18 7:27 ` Hugh Dickins
2005-11-18 7:46 ` Andrew Morton
2005-11-18 8:04 ` David S. Miller
2005-11-18 8:12 ` Hugh Dickins
2005-11-18 8:02 ` Hugh Dickins
2005-11-18 8:08 ` David S. Miller
2005-11-18 8:13 ` Hugh Dickins
2005-11-18 8:36 ` David S. Miller
2005-11-18 9:33 ` Hugh Dickins
2005-11-18 21:08 ` Dave Jones
2005-11-18 19:12 ` Alan Cox
2005-11-17 19:38 ` [PATCH 08/11] unpaged: anon in VM_UNPAGED Hugh Dickins
2005-11-17 19:38 ` [PATCH 09/11] unpaged: ZERO_PAGE " Hugh Dickins
2005-11-17 21:25 ` Ingo Oeser
2005-11-18 19:58 ` Hugh Dickins
2005-11-17 19:39 ` [PATCH 10/11] unpaged: PG_reserved bad_page Hugh Dickins
2005-11-17 19:40 ` [PATCH 11/11] unpaged: copy_page_range vma Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051117.152900.72981605.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®