From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
Karsten Wiese <annabellesgarden@yahoo.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH 03/11] unpaged: sound nopage get_page
Date: Thu, 17 Nov 2005 19:31:36 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.61.0511171930090.4563@goblin.wat.veritas.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0511171925290.4563@goblin.wat.veritas.com>
Something noticed when studying use of VM_RESERVED in different drivers:
snd_usX2Y_hwdep_pcm_vm_nopage omitted to get_page: fixed.
And how did this work before? Aargh! That nopage is returning a page
from within a buffer allocated by snd_malloc_pages, which allocates a
high-order page, then does SetPageReserved on each 0-order page within.
That would have worked in 2.6.14, because when the area was unmapped,
PageReserved inhibited put_page. 2.6.15-rc1 removed that inhibition
(while leaving ineffective PageReserveds around for now), but it hasn't
caused trouble because.. we've not been freeing from VM_RESERVED at all.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
sound/usb/usx2y/usx2yhwdeppcm.c | 1 +
1 files changed, 1 insertion(+)
--- unpaged02/sound/usb/usx2y/usx2yhwdeppcm.c 2005-11-12 09:01:30.000000000 +0000
+++ unpaged03/sound/usb/usx2y/usx2yhwdeppcm.c 2005-11-17 15:10:34.000000000 +0000
@@ -691,6 +691,7 @@ static struct page * snd_usX2Y_hwdep_pcm
snd_assert((offset % PAGE_SIZE) == 0, return NOPAGE_OOM);
vaddr = (char*)((usX2Ydev_t*)area->vm_private_data)->hwdep_pcm_shm + offset;
page = virt_to_page(vaddr);
+ get_page(page);
if (type)
*type = VM_FAULT_MINOR;
next prev parent reply other threads:[~2005-11-17 19:32 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-17 19:28 [PATCH 00/11] unpaged: PageReserved VM fixups Hugh Dickins
2005-11-17 19:29 ` [PATCH 01/11] unpaged: get_user_pages VM_RESERVED Hugh Dickins
2005-11-17 23:29 ` David S. Miller
2005-11-17 19:30 ` [PATCH 02/11] unpaged: private write VM_RESERVED Hugh Dickins
2005-11-17 19:41 ` Dave Jones
2005-11-17 20:46 ` Dominik Brodowski
2005-11-17 20:51 ` Dave Jones
2005-11-17 23:58 ` David S. Miller
2005-11-18 7:12 ` Dominik Brodowski
2005-11-18 7:59 ` David S. Miller
2005-11-17 20:59 ` Dominik Brodowski
2005-11-17 23:36 ` David S. Miller
2005-11-17 19:31 ` Hugh Dickins [this message]
2005-11-17 23:41 ` [PATCH 03/11] unpaged: sound nopage get_page David S. Miller
2005-11-17 19:32 ` [PATCH 04/11] unpaged: unifdefed PageCompound Hugh Dickins
2005-11-17 23:43 ` David S. Miller
2005-11-19 20:15 ` Hugh Dickins
2005-11-19 20:55 ` William Lee Irwin III
2005-11-19 21:41 ` David S. Miller
2005-11-19 21:58 ` William Lee Irwin III
2005-11-17 19:34 ` [PATCH 05/11] unpaged: VM_UNPAGED Hugh Dickins
2005-11-17 20:59 ` William Lee Irwin III
2005-11-17 23:46 ` David S. Miller
2005-11-17 19:36 ` [PATCH 06/11] unpaged: VM_NONLINEAR VM_RESERVED Hugh Dickins
2005-11-17 19:37 ` [PATCH 07/11] unpaged: COW on VM_UNPAGED Hugh Dickins
2005-11-17 23:52 ` David S. Miller
2005-11-18 5:46 ` Nick Piggin
2005-11-18 6:45 ` David S. Miller
2005-11-18 7:27 ` Hugh Dickins
2005-11-18 7:46 ` Andrew Morton
2005-11-18 8:04 ` David S. Miller
2005-11-18 8:12 ` Hugh Dickins
2005-11-18 8:02 ` Hugh Dickins
2005-11-18 8:08 ` David S. Miller
2005-11-18 8:13 ` Hugh Dickins
2005-11-18 8:36 ` David S. Miller
2005-11-18 9:33 ` Hugh Dickins
2005-11-18 21:08 ` Dave Jones
2005-11-18 19:12 ` Alan Cox
2005-11-17 19:38 ` [PATCH 08/11] unpaged: anon in VM_UNPAGED Hugh Dickins
2005-11-17 19:38 ` [PATCH 09/11] unpaged: ZERO_PAGE " Hugh Dickins
2005-11-17 21:25 ` Ingo Oeser
2005-11-18 19:58 ` Hugh Dickins
2005-11-17 19:39 ` [PATCH 10/11] unpaged: PG_reserved bad_page Hugh Dickins
2005-11-17 19:40 ` [PATCH 11/11] unpaged: copy_page_range vma Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0511171930090.4563@goblin.wat.veritas.com \
--to=hugh@veritas.com \
--cc=akpm@osdl.org \
--cc=annabellesgarden@yahoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®