* Re: [PATCH 05/20] V4L/DVB (3343) Add support for DViCO FusionHDTV DVB-T USB devices
[not found] ` <20060112025552.PS20388000005@infradead.org>
@ 2006-01-12 3:51 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2006-01-12 3:51 UTC (permalink / raw)
To: mchehab
Cc: linux-kernel, linux-dvb-maintainer, video4linux-list, mkrufky, mchehab
mchehab@infradead.org wrote:
>
> + .urb = {
> + .type = DVB_USB_BULK,
> + .count = 5,
> + .endpoint = 0x04,
> + .u = {
> + .bulk = {
> + .buffersize = 8192,
> + }
> + }
> + },
Note that we don't need to go through this pain any more. With the
gcc-2.95 abandonment we can do
.u.bulk.buffersize = 8192;
^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20060112025553.PS72536800009@infradead.org>]
* Re: [PATCH 09/20] V4L/DVB (3344d) Stradis video little cleanup
[not found] ` <20060112025553.PS72536800009@infradead.org>
@ 2006-01-12 3:53 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2006-01-12 3:53 UTC (permalink / raw)
To: mchehab
Cc: linux-kernel, linux-dvb-maintainer, video4linux-list, xslaby,
jirislaby, mchehab
mchehab@infradead.org wrote:
>
> +errosd:
> + vfree(saa->osdbuf);
> + saa->osdbuf = NULL;
> +erraud:
> + vfree(saa->audbuf);
> + saa->audbuf = NULL;
> +errvid:
> + vfree(saa->vidbuf);
> + saa->vidbuf = NULL;
> +err:
> + return -ENOMEM;
> }
vfree(NULL) is legal, so this could be:
error:
vfree(saa->osdbuf);
vfree(saa->audbuf);
vfree(saa->vidbuf);
saa->vidbuf = NULL;
saa->osdbuf = NULL;
saa->audbuf = NULL;
^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20060112025557.PS14543900013@infradead.org>]
* Re: [PATCH 13/20] V4L/DVB (3345) Fixes some bad global variables
[not found] ` <20060112025557.PS14543900013@infradead.org>
@ 2006-01-12 3:54 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2006-01-12 3:54 UTC (permalink / raw)
To: mchehab
Cc: linux-kernel, linux-dvb-maintainer, video4linux-list, mchehab, mchehab
mchehab@infradead.org wrote:
>
> +int msp_debug = 0; /* msp_debug output */
> +int msp_once = 0; /* no continous stereo monitoring */
> +int msp_amsound = 0; /* hard-wire AM sound at 6.5 Hz (france),
> the autoscan seems work well only with FM... */
> -int standard = 1; /* Override auto detect of audio standard, if needed. */
> -int dolby = 0;
> +int msp_standard = 1; /* Override auto detect of audio msp_standard, if needed. */
> +int msp_dolby = 0;
argh, I removed all the "= 0"s and they've come back.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-01-12 3:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20060112025516.PS38541900000@infradead.org>
[not found] ` <20060112025552.PS20388000005@infradead.org>
2006-01-12 3:51 ` [PATCH 05/20] V4L/DVB (3343) Add support for DViCO FusionHDTV DVB-T USB devices Andrew Morton
[not found] ` <20060112025553.PS72536800009@infradead.org>
2006-01-12 3:53 ` [PATCH 09/20] V4L/DVB (3344d) Stradis video little cleanup Andrew Morton
[not found] ` <20060112025557.PS14543900013@infradead.org>
2006-01-12 3:54 ` [PATCH 13/20] V4L/DVB (3345) Fixes some bad global variables Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®