* [PATCH] USB: Fix masking bug initialization of Freescale EHCI controller
@ 2006-01-23 19:48 Kumar Gala
2006-01-24 16:11 ` [linux-usb-devel] " David Brownell
0 siblings, 1 reply; 2+ messages in thread
From: Kumar Gala @ 2006-01-23 19:48 UTC (permalink / raw)
To: dbrownell; +Cc: Randy Vinson, linux-kernel, linux-usb-devel
In setting up the of PHY we masked off too many bits, instead just
initialize PORTSC for the type of PHY we are using.
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
commit 2497a5e4242d500178d6d0f0ce4ee9249a38f5dc
tree 71f036ecd23dffb224963b4aabe4f857ba99845b
parent fe49a3f53c2572bf26a9dfd77e54fda1aa853887
author Kumar Gala <galak@kernel.crashing.org> Mon, 23 Jan 2006 13:53:09 -0600
committer Kumar Gala <galak@kernel.crashing.org> Mon, 23 Jan 2006 13:53:09 -0600
drivers/usb/host/ehci-fsl.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index 6d82054..f40ee41 100644
--- a/drivers/usb/host/ehci-fsl.c
+++ b/drivers/usb/host/ehci-fsl.c
@@ -160,8 +160,7 @@ static void mpc83xx_setup_phy(struct ehc
enum fsl_usb2_phy_modes phy_mode,
unsigned int port_offset)
{
- u32 portsc = readl(&ehci->regs->port_status[port_offset]);
- portsc &= ~PORT_PTS_MSK;
+ u32 portsc = 0;
switch (phy_mode) {
case FSL_USB2_PHY_ULPI:
portsc |= PORT_PTS_ULPI;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [linux-usb-devel] [PATCH] USB: Fix masking bug initialization of Freescale EHCI controller
2006-01-23 19:48 [PATCH] USB: Fix masking bug initialization of Freescale EHCI controller Kumar Gala
@ 2006-01-24 16:11 ` David Brownell
0 siblings, 0 replies; 2+ messages in thread
From: David Brownell @ 2006-01-24 16:11 UTC (permalink / raw)
To: linux-usb-devel; +Cc: Kumar Gala, dbrownell, Randy Vinson, linux-kernel
On Monday 23 January 2006 11:48 am, Kumar Gala wrote:
> In setting up the of PHY we masked off too many bits, instead just
> initialize PORTSC for the type of PHY we are using.
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> commit 2497a5e4242d500178d6d0f0ce4ee9249a38f5dc
> tree 71f036ecd23dffb224963b4aabe4f857ba99845b
> parent fe49a3f53c2572bf26a9dfd77e54fda1aa853887
> author Kumar Gala <galak@kernel.crashing.org> Mon, 23 Jan 2006 13:53:09 -0600
> committer Kumar Gala <galak@kernel.crashing.org> Mon, 23 Jan 2006 13:53:09 -0600
>
> drivers/usb/host/ehci-fsl.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index 6d82054..f40ee41 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -160,8 +160,7 @@ static void mpc83xx_setup_phy(struct ehc
> enum fsl_usb2_phy_modes phy_mode,
> unsigned int port_offset)
> {
> - u32 portsc = readl(&ehci->regs->port_status[port_offset]);
> - portsc &= ~PORT_PTS_MSK;
> + u32 portsc = 0;
> switch (phy_mode) {
> case FSL_USB2_PHY_ULPI:
> portsc |= PORT_PTS_ULPI;
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-01-24 16:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-23 19:48 [PATCH] USB: Fix masking bug initialization of Freescale EHCI controller Kumar Gala
2006-01-24 16:11 ` [linux-usb-devel] " David Brownell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®