From: Andrew Morton <akpm@osdl.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: wli@holomorphy.com, nickpiggin@yahoo.com.au,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/3] compound page: use page[1].lru
Date: Sun, 12 Feb 2006 18:13:12 -0800 [thread overview]
Message-ID: <20060212181312.11392d12.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0602130043480.17715@goblin.wat.veritas.com>
Hugh Dickins <hugh@veritas.com> wrote:
>
> On Sun, 12 Feb 2006, Andrew Morton wrote:
> >
> > I'm scratching my head over flush_dcache_page() on, say, sparc64. For
> > example, the one in fs/direct-io.c. With this patch, we'll call
> > flush_dcache_page_impl(), which at least won't crash. Before the patch I
> > think we'd just do random stuff.
>
> A head-scratching business indeed. I think your description is right.
>
> I haven't looked up the intersection of the set of arches which have
> hugetlb with the set of arches which do something in flush_dcache_page,
> but maybe you have, and found sparc64 the only or most significant.
We have a page which has no ->mapping, but lo, it's mmapped by userspace
and can be MAP_SHARED between different CPUs and processes.
Yes, I suspect it'll do the wrong thing in unpleasantly subtle ways.
(cc's davem and runs away).
next prev parent reply other threads:[~2006-02-13 2:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-12 19:46 Hugh Dickins
2006-02-12 19:47 ` [PATCH 2/3] compound page: default destructor Hugh Dickins
2006-02-12 19:50 ` [PATCH 3/3] compound page: no access_process_vm check Hugh Dickins
2006-02-12 21:54 ` [PATCH 1/3] compound page: use page[1].lru Andrew Morton
2006-02-13 0:57 ` Hugh Dickins
2006-02-13 2:13 ` Andrew Morton [this message]
2006-02-13 7:05 ` David S. Miller
2006-02-13 7:12 ` Andrew Morton
2006-02-13 7:59 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060212181312.11392d12.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®