mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@osdl.org>
Cc: David Gibson <david@gibson.dropbear.id.au>, linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] compound page: no access_process_vm check
Date: Sun, 12 Feb 2006 19:50:02 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.61.0602121947440.15774@goblin.wat.veritas.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0602121943150.15774@goblin.wat.veritas.com>

The PageCompound check before access_process_vm's set_page_dirty_lock is
no longer necessary, so remove it.  But leave the PageCompound checks in
bio_set_pages_dirty, dio_bio_complete and nfs_free_user_pages: at least
some of those were introduced as a little optimization on hugetlb pages.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
---

 kernel/ptrace.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)

--- 2.6.16-rc2-git11/kernel/ptrace.c	2006-02-03 09:32:51.000000000 +0000
+++ 2.6.16-rc2-git11+/kernel/ptrace.c	2006-02-10 20:07:05.000000000 +0000
@@ -242,8 +242,7 @@ int access_process_vm(struct task_struct
 		if (write) {
 			copy_to_user_page(vma, page, addr,
 					  maddr + offset, buf, bytes);
-			if (!PageCompound(page))
-				set_page_dirty_lock(page);
+			set_page_dirty_lock(page);
 		} else {
 			copy_from_user_page(vma, page, addr,
 					    buf, maddr + offset, bytes);

  parent reply	other threads:[~2006-02-12 19:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-12 19:46 [PATCH 1/3] compound page: use page[1].lru Hugh Dickins
2006-02-12 19:47 ` [PATCH 2/3] compound page: default destructor Hugh Dickins
2006-02-12 19:50 ` Hugh Dickins [this message]
2006-02-12 21:54 ` [PATCH 1/3] compound page: use page[1].lru Andrew Morton
2006-02-13  0:57   ` Hugh Dickins
2006-02-13  2:13     ` Andrew Morton
2006-02-13  7:05       ` David S. Miller
2006-02-13  7:12         ` Andrew Morton
2006-02-13  7:59           ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0602121947440.15774@goblin.wat.veritas.com \
    --to=hugh@veritas.com \
    --cc=akpm@osdl.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®