From: Sam Ravnborg <sam@ravnborg.org>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Herbert Poetzl <herbert@13thfloor.at>,
Linux Kernel ML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] duplicate #include check for build system
Date: Tue, 21 Feb 2006 18:52:46 +0100 [thread overview]
Message-ID: <20060221175246.GA9070@mars.ravnborg.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0602210149190.6773@iabervon.org>
On Tue, Feb 21, 2006 at 02:29:12AM -0500, Daniel Barkalow wrote:
> On Tue, 21 Feb 2006, Herbert Poetzl wrote:
> I think the kernel style is to encourage duplicate includes, rather than
> removing them. Removing duplicate includes won't remove any dependancies
> (since the includes that they duplicate will remain).
The style as I have understood it is that each .h file in include/linux/
are supposed to be self-contained. So it includes what is needs, and the
'what it needs' are kept small.
Keeping the 'what it needs' part small is a challenge resulting in
smaller .h files. But also a good way to keep related things together.
Sam
next prev parent reply other threads:[~2006-02-21 17:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-21 1:48 Herbert Poetzl
2006-02-21 6:10 ` Sam Ravnborg
2006-02-21 7:29 ` Daniel Barkalow
2006-02-21 17:52 ` Sam Ravnborg [this message]
2006-02-22 0:11 ` Herbert Poetzl
2006-02-22 0:18 ` Randy.Dunlap
2006-02-22 0:26 ` Herbert Poetzl
2006-02-22 0:28 ` Randy.Dunlap
2006-02-22 5:57 ` Sam Ravnborg
2006-02-24 7:23 ` Jan Engelhardt
2006-02-25 2:59 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060221175246.GA9070@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=barkalow@iabervon.org \
--cc=herbert@13thfloor.at \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®