From: Sam Ravnborg <sam@ravnborg.org>
To: Daniel Barkalow <barkalow@iabervon.org>,
Linux Kernel ML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] duplicate #include check for build system
Date: Wed, 22 Feb 2006 06:57:19 +0100 [thread overview]
Message-ID: <20060222055719.GA9078@mars.ravnborg.org> (raw)
In-Reply-To: <20060222001153.GF20204@MAIL.13thfloor.at>
On Wed, Feb 22, 2006 at 01:11:53AM +0100, Herbert Poetzl wrote:
> >
> > Keeping the 'what it needs' part small is a challenge resulting in
> > smaller .h files. But also a good way to keep related things together.
>
> glad that I stimulated a philosophical discussion
> about the kernel header files and what they should
> include or not ...
>
> but the idea was more to give the developers an
> instrument to verify that they are not including
> stuff several times, and that's actually in .h
> and .c files, because it seems that often the same
> header file is included twice in the _same_ file
>
> anyway, was this a positive or negative reply?
If you can restrict the tool to locate the cases where
a header file is included twice in the same file - then
this is a positive reply.
If you limit the check to the top-level file this is fine,
but I would not be suprised is one or a few .h files
has duplicated includes too.
Sam
next prev parent reply other threads:[~2006-02-22 5:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-21 1:48 Herbert Poetzl
2006-02-21 6:10 ` Sam Ravnborg
2006-02-21 7:29 ` Daniel Barkalow
2006-02-21 17:52 ` Sam Ravnborg
2006-02-22 0:11 ` Herbert Poetzl
2006-02-22 0:18 ` Randy.Dunlap
2006-02-22 0:26 ` Herbert Poetzl
2006-02-22 0:28 ` Randy.Dunlap
2006-02-22 5:57 ` Sam Ravnborg [this message]
2006-02-24 7:23 ` Jan Engelhardt
2006-02-25 2:59 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060222055719.GA9078@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=barkalow@iabervon.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®