mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
To: johnstul@us.ibm.com
Cc: akpm@osdl.org, zippel@linux-m68k.org, clameter@engr.sgi.com,
	linux-kernel@vger.kernel.org, ralf@linux-mips.org, ak@muc.de
Subject: Re: [PATCH] simplify update_times (avoid jiffies/jiffies_64 aliasing problem)
Date: Sun, 05 Mar 2006 02:15:42 +0900 (JST)	[thread overview]
Message-ID: <20060305.021542.126141997.anemo@mba.ocn.ne.jp> (raw)
In-Reply-To: <1141417048.9727.60.camel@cog.beaverton.ibm.com>

>>>>> On Fri, 03 Mar 2006 12:17:28 -0800, john stultz <johnstul@us.ibm.com> said:

john> I'm not opposed to queuing it up as it seems like a logical
john> cleanup. I'd be fine with it going in before my patch, however
john> it still needs to address i386 lost tick compensation.  I worry
john> that addressing that issue before my patchset (which makes the
john> lost tick compensation unnecessary) might be a bit more
john> complex. I think it would be easier going in after my patch. I
john> do think the barrier fix (with a comment) is a good short term
john> fix.

john> Atsushi: Your thoughts?

I agree.  I missed i386 lost tick case and it seems more complex than
x86_64 case.  Your patchset looks to make this cleanup very easy.
Then, here is an updated barrier fix patch.


Add an optimization barrier to prevent prefetching jiffies before
incrementing jiffies_64.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

diff --git a/kernel/timer.c b/kernel/timer.c
index fc6646f..decd19e 100644
--- a/kernel/timer.c
+++ b/kernel/timer.c
@@ -925,6 +925,8 @@ static inline void update_times(void)
 void do_timer(struct pt_regs *regs)
 {
 	jiffies_64++;
+	/* prevent loading jiffies before storing new jiffies_64 value. */
+	barrier();
 	update_times();
 	softlockup_tick(regs);
 }

  parent reply	other threads:[~2006-03-04 17:15 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-02 14:02 Atsushi Nemoto
2006-03-02 15:51 ` Atsushi Nemoto
2006-03-02 19:09 ` Christoph Lameter
2006-03-03  2:44   ` Atsushi Nemoto
2006-03-03  3:04     ` Andrew Morton
2006-03-03  3:20       ` Andi Kleen
2006-03-03  4:31       ` Atsushi Nemoto
2006-03-03  5:45         ` David S. Miller
2006-03-03 16:26           ` Atsushi Nemoto
2006-03-03 16:31         ` Atsushi Nemoto
2006-03-04  8:18           ` Andrew Morton
2006-03-04 11:20             ` Andi Kleen
2006-03-04 11:40               ` Andrew Morton
2006-03-04  5:21                 ` Andi Kleen
2006-03-04 23:13                 ` Paul Mackerras
2006-03-06  2:32                   ` Atsushi Nemoto
2006-03-04 11:42               ` Paul Mackerras
2006-03-04 11:44                 ` Andrew Morton
2006-03-04 12:33                   ` Paul Mackerras
2006-03-04 16:43                     ` Atsushi Nemoto
2006-03-03 20:17       ` john stultz
2006-03-03 21:15         ` Andrew Morton
2006-03-04 17:15         ` Atsushi Nemoto [this message]
2006-07-30 14:54           ` Atsushi Nemoto
2006-07-31 10:36             ` Martin Schwidefsky
2006-08-01 14:44               ` Atsushi Nemoto
2006-08-02 12:50                 ` Martin Schwidefsky
2006-08-03 15:53                   ` Atsushi Nemoto
2006-08-04 14:02                     ` Martin Schwidefsky
2006-08-06 16:13                       ` Atsushi Nemoto
2006-08-07 11:28                         ` Martin Schwidefsky
2006-08-07 19:58                         ` Andrew Morton
2006-08-08  8:11                           ` Martin Schwidefsky
2006-08-09 15:07                           ` Atsushi Nemoto
2006-03-03 18:13     ` john stultz
2006-03-04  2:34       ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060305.021542.126141997.anemo@mba.ocn.ne.jp \
    --to=anemo@mba.ocn.ne.jp \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=clameter@engr.sgi.com \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®