mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
To: schwidefsky@googlemail.com
Cc: johnstul@us.ibm.com, akpm@osdl.org, zippel@linux-m68k.org,
	clameter@engr.sgi.com, linux-kernel@vger.kernel.org,
	ralf@linux-mips.org, ak@muc.de
Subject: Re: [PATCH] simplify update_times (avoid jiffies/jiffies_64 aliasing problem)
Date: Tue, 01 Aug 2006 23:44:22 +0900 (JST)	[thread overview]
Message-ID: <20060801.234422.25910237.anemo@mba.ocn.ne.jp> (raw)
In-Reply-To: <6e0cfd1d0607310336o355693a5l939db098b9210d81@mail.gmail.com>

On Mon, 31 Jul 2006 12:36:38 +0200, "Martin Schwidefsky" <schwidefsky@googlemail.com> wrote:
> > --- a/arch/x86_64/kernel/time.c
> > +++ b/arch/x86_64/kernel/time.c
> > @@ -423,7 +423,8 @@ #endif
> >
> >         if (lost > 0) {
> >                 handle_lost_ticks(lost, regs);
> > -               jiffies += lost;
> > +               while (lost--)
> > +                       do_timer(regs);
> >         }
> >
> >  /*
> 
> I think that this is going into the wrong direction. There are a
> number of architectures that call do_timer(regs) in a while loop. It
> would be much nicer if do_timer would get the number of passed ticks
> as an argument. And the "regs" argument to do_timer is just useless.

But normally do_timer() is called just once, isn't it?  These loops
are just for lost ticks, which would be rarely happened.  So I think
tunning for usual case is better.

I agree that the "regs" argument is useless.  Another candidate for
cleanup.

---
Atsushi Nemoto

  reply	other threads:[~2006-08-01 14:42 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-02 14:02 Atsushi Nemoto
2006-03-02 15:51 ` Atsushi Nemoto
2006-03-02 19:09 ` Christoph Lameter
2006-03-03  2:44   ` Atsushi Nemoto
2006-03-03  3:04     ` Andrew Morton
2006-03-03  3:20       ` Andi Kleen
2006-03-03  4:31       ` Atsushi Nemoto
2006-03-03  5:45         ` David S. Miller
2006-03-03 16:26           ` Atsushi Nemoto
2006-03-03 16:31         ` Atsushi Nemoto
2006-03-04  8:18           ` Andrew Morton
2006-03-04 11:20             ` Andi Kleen
2006-03-04 11:40               ` Andrew Morton
2006-03-04  5:21                 ` Andi Kleen
2006-03-04 23:13                 ` Paul Mackerras
2006-03-06  2:32                   ` Atsushi Nemoto
2006-03-04 11:42               ` Paul Mackerras
2006-03-04 11:44                 ` Andrew Morton
2006-03-04 12:33                   ` Paul Mackerras
2006-03-04 16:43                     ` Atsushi Nemoto
2006-03-03 20:17       ` john stultz
2006-03-03 21:15         ` Andrew Morton
2006-03-04 17:15         ` Atsushi Nemoto
2006-07-30 14:54           ` Atsushi Nemoto
2006-07-31 10:36             ` Martin Schwidefsky
2006-08-01 14:44               ` Atsushi Nemoto [this message]
2006-08-02 12:50                 ` Martin Schwidefsky
2006-08-03 15:53                   ` Atsushi Nemoto
2006-08-04 14:02                     ` Martin Schwidefsky
2006-08-06 16:13                       ` Atsushi Nemoto
2006-08-07 11:28                         ` Martin Schwidefsky
2006-08-07 19:58                         ` Andrew Morton
2006-08-08  8:11                           ` Martin Schwidefsky
2006-08-09 15:07                           ` Atsushi Nemoto
2006-03-03 18:13     ` john stultz
2006-03-04  2:34       ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060801.234422.25910237.anemo@mba.ocn.ne.jp \
    --to=anemo@mba.ocn.ne.jp \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=clameter@engr.sgi.com \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=schwidefsky@googlemail.com \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®