From: Paul Jackson <pj@sgi.com>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: akpm@osdl.org, Simon.Derr@bull.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Cpuset: remove unnecessary NULL check
Date: Sun, 19 Mar 2006 06:56:14 -0800 [thread overview]
Message-ID: <20060319065614.371823f2.pj@sgi.com> (raw)
In-Reply-To: <m1acbmzfw5.fsf@ebiederm.dsl.xmission.com>
Eric wrote:
> Comments that refer to a nebulous hack ...
Well, in this case, it wasn't so nebulous, to me anyway.
The "Hack" referred to has a big fat comment beginning:
*
* Hack:
*
* Set the exiting tasks cpuset to the root cpuset (top_cpuset).
*
* Don't leave a task unable to allocate memory, as ...
and is labeled at the scene of the Hack with:
tsk->cpuset = &top_cpuset; /* Hack - see comment above */
So "Hack" was intended as a proper noun, not a nebulous generic term.
But, sure, hard to argue with anyone wanting improved comments.
And while I'm at it, I will change the name of this Hack to something
less generic ... say "the_top_cpuset_hack".
Patch coming soon.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next prev parent reply other threads:[~2006-03-19 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-19 8:57 Paul Jackson
2006-03-19 14:08 ` Eric W. Biederman
2006-03-19 14:56 ` Paul Jackson [this message]
2006-03-19 15:06 ` Eric W. Biederman
2006-03-19 15:10 ` Eric W. Biederman
-- strict thread matches above, loose matches on Subject: below --
2006-03-02 7:08 Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060319065614.371823f2.pj@sgi.com \
--to=pj@sgi.com \
--cc=Simon.Derr@bull.net \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome