mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Paul Jackson <pj@sgi.com>
Cc: akpm@osdl.org, Simon.Derr@bull.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Cpuset: remove unnecessary NULL check
Date: Sun, 19 Mar 2006 08:10:52 -0700	[thread overview]
Message-ID: <m1wteqxyf7.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20060319065614.371823f2.pj@sgi.com> (Paul Jackson's message of "Sun, 19 Mar 2006 06:56:14 -0800")

Paul Jackson <pj@sgi.com> writes:

> Eric wrote:
>> Comments that refer to a nebulous hack ...
>
> Well, in this case, it wasn't so nebulous, to me anyway.

Right.  The core problem was there was not enough context to see
what the dependency was from the comment.  Having to read
another comment to understand the comment you are reading
usually breaks after a while.

Now that we have git the problem is less severe because we
can look in the history and see what the comment meant when
it was written but that is still a hassle.

> Patch coming soon.

Thanks.

Eric

  parent reply	other threads:[~2006-03-19 15:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-19  8:57 Paul Jackson
2006-03-19 14:08 ` Eric W. Biederman
2006-03-19 14:56   ` Paul Jackson
2006-03-19 15:06     ` Eric W. Biederman
2006-03-19 15:10     ` Eric W. Biederman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-03-02  7:08 Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1wteqxyf7.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=Simon.Derr@bull.net \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pj@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®