From: Paul Jackson <pj@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Simon.Derr@bull.net, Paul Jackson <pj@sgi.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] Cpuset: remove unnecessary NULL check
Date: Sun, 19 Mar 2006 00:57:43 -0800 [thread overview]
Message-ID: <20060319085743.18841.45970.sendpatchset@jackhammer.engr.sgi.com> (raw)
From: Paul Jackson <pj@sgi.com>
Remove a no longer needed test for NULL cpuset pointer, with
a little comment explaining why the test isn't needed.
Signed-off-by: Paul Jackson <pj@sgi.com>
---
kernel/cpuset.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
--- 2.6.16-rc6-mm2.orig/kernel/cpuset.c 2006-03-18 22:15:33.912350380 -0800
+++ 2.6.16-rc6-mm2/kernel/cpuset.c 2006-03-18 22:15:43.681994273 -0800
@@ -2375,12 +2375,12 @@ void __cpuset_memory_pressure_bump(void)
* - No need to task_lock(tsk) on this tsk->cpuset reference, as it
* doesn't really matter if tsk->cpuset changes after we read it,
* and we take manage_mutex, keeping attach_task() from changing it
- * anyway.
+ * anyway. No need to check that tsk->cpuset != NULL, thanks to the
+ * cpuset_exit() Hack.
*/
static int proc_cpuset_show(struct seq_file *m, void *v)
{
- struct cpuset *cs;
struct pid *pid;
struct task_struct *tsk;
char *buf;
@@ -2399,11 +2399,8 @@ static int proc_cpuset_show(struct seq_f
retval = -EINVAL;
mutex_lock(&manage_mutex);
- cs = tsk->cpuset;
- if (!cs)
- goto out_unlock;
- retval = cpuset_path(cs, buf, PAGE_SIZE);
+ retval = cpuset_path(tsk->cpuset, buf, PAGE_SIZE);
if (retval < 0)
goto out_unlock;
seq_puts(m, buf);
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.650.933.1373
next reply other threads:[~2006-03-19 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-19 8:57 Paul Jackson [this message]
2006-03-19 14:08 ` Eric W. Biederman
2006-03-19 14:56 ` Paul Jackson
2006-03-19 15:06 ` Eric W. Biederman
2006-03-19 15:10 ` Eric W. Biederman
-- strict thread matches above, loose matches on Subject: below --
2006-03-02 7:08 Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060319085743.18841.45970.sendpatchset@jackhammer.engr.sgi.com \
--to=pj@sgi.com \
--cc=Simon.Derr@bull.net \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome