* [PATCH] edac_752x needs CONFIG_HOTPLUG
@ 2006-03-27 23:06 Randy.Dunlap
2006-03-27 23:40 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Randy.Dunlap @ 2006-03-27 23:06 UTC (permalink / raw)
To: norsk5, dthompson; +Cc: dsp, dave_peterson, lkml, akpm
From: Randy Dunlap <rdunlap@xenotime.net>
EDAC_752X uses pci_scan_single_device(), which is only available
if CONFIG_HOTPLUG is enabled, so limit this driver with HOTPLUG.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
drivers/edac/Kconfig | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2616-g13.orig/drivers/edac/Kconfig
+++ linux-2616-g13/drivers/edac/Kconfig
@@ -71,7 +71,7 @@ config EDAC_E7XXX
config EDAC_E752X
tristate "Intel e752x (e7520, e7525, e7320)"
- depends on EDAC_MM_EDAC && PCI && X86
+ depends on EDAC_MM_EDAC && PCI && X86 && HOTPLUG
help
Support for error detection and correction on the Intel
E7520, E7525, E7320 server chipsets.
---
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] edac_752x needs CONFIG_HOTPLUG
2006-03-27 23:06 [PATCH] edac_752x needs CONFIG_HOTPLUG Randy.Dunlap
@ 2006-03-27 23:40 ` Andrew Morton
2006-03-27 23:49 ` Randy.Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2006-03-27 23:40 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: norsk5, dthompson, dsp, dave_peterson, linux-kernel, Greg KH
"Randy.Dunlap" <rdunlap@xenotime.net> wrote:
>
> EDAC_752X uses pci_scan_single_device(), which is only available
> if CONFIG_HOTPLUG is enabled
hm. That's not a hotpluggable device, surely?
If not then either a) PCI should be implementing pci_scan_single_device()
if !CONFIG_HOTPLUG or b) EDAC shouldn't be using pci_scan_single_device().
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] edac_752x needs CONFIG_HOTPLUG
2006-03-27 23:40 ` Andrew Morton
@ 2006-03-27 23:49 ` Randy.Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy.Dunlap @ 2006-03-27 23:49 UTC (permalink / raw)
To: Andrew Morton; +Cc: norsk5, dthompson, dsp, dave_peterson, linux-kernel, greg
On Mon, 27 Mar 2006 15:40:55 -0800 Andrew Morton wrote:
> "Randy.Dunlap" <rdunlap@xenotime.net> wrote:
> >
> > EDAC_752X uses pci_scan_single_device(), which is only available
> > if CONFIG_HOTPLUG is enabled
>
> hm. That's not a hotpluggable device, surely?
>
> If not then either a) PCI should be implementing pci_scan_single_device()
> if !CONFIG_HOTPLUG or b) EDAC shouldn't be using pci_scan_single_device().
or just that one if block should be surrounded by CONFIG_HOTPLUG
(done cleanly, of course).
---
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-03-27 23:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-03-27 23:06 [PATCH] edac_752x needs CONFIG_HOTPLUG Randy.Dunlap
2006-03-27 23:40 ` Andrew Morton
2006-03-27 23:49 ` Randy.Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®