From: Jesper Juhl <jesper.juhl@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Adam Belay <ambx1@neo.rr.com>,
Jesper Juhl <jesper.juhl@gmail.com>,
Andrew Morton <akpm@osdl.org>
Subject: [PATCH][resend] fix resource leak in pnp card_probe()
Date: Sat, 13 May 2006 22:35:42 +0200 [thread overview]
Message-ID: <200605132235.42338.jesper.juhl@gmail.com> (raw)
(resend of patch already send once on 23/03-2006
- still applies cleanly to latest -git)
We can leak `clink' in drivers/pnp/card.c::card_probe()
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
drivers/pnp/card.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)
--- linux-2.6.16-mm1-orig/drivers/pnp/card.c 2006-03-26 13:43:38.000000000 +0200
+++ linux-2.6.16-mm1/drivers/pnp/card.c 2006-03-26 15:45:00.000000000 +0200
@@ -81,8 +81,10 @@ static int card_probe(struct pnp_card *
}
kfree(clink);
}
- } else
+ } else {
+ kfree(clink);
return 1;
+ }
}
return 0;
}
next reply other threads:[~2006-05-13 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-13 20:35 Jesper Juhl [this message]
2006-05-14 9:38 ` Andrew Morton
2006-05-14 9:48 ` Keith Owens
2006-05-14 9:58 ` Andrew Morton
2006-05-14 10:42 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605132235.42338.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=akpm@osdl.org \
--cc=ambx1@neo.rr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®