From: Andrew Morton <akpm@osdl.org>
To: Keith Owens <kaos@ocs.com.au>
Cc: jesper.juhl@gmail.com, linux-kernel@vger.kernel.org, ambx1@neo.rr.com
Subject: Re: [PATCH][resend] fix resource leak in pnp card_probe()
Date: Sun, 14 May 2006 02:58:38 -0700 [thread overview]
Message-ID: <20060514025838.0a7a846f.akpm@osdl.org> (raw)
In-Reply-To: <31862.1147600089@ocs3>
Keith Owens <kaos@ocs.com.au> wrote:
>
> >+ clink = pnp_alloc(sizeof(*clink));
> >+ if (!clink)
> >+ return 0;
> >+ clink->card = card;
> >+ clink->driver = drv;
> >+ clink->pm_state = PMSG_ON;
>
> Memory leak of clink on next test.
>
> >+
> >+ if (drv->probe(clink, id) >= 0)
> >+ return 1;
> >+
> >+ /* Recovery */
> >+ card_for_each_dev(card, dev) {
> >+ if (dev->card_link == clink)
> >+ pnp_release_card_device(dev);
> > }
> >+ kfree(clink);
> > return 0;
> > }
No, if ->probe succeeded, it took over control of the memory at *clink.
It's all rather twisty and quite undocumented.
next prev parent reply other threads:[~2006-05-14 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-13 20:35 Jesper Juhl
2006-05-14 9:38 ` Andrew Morton
2006-05-14 9:48 ` Keith Owens
2006-05-14 9:58 ` Andrew Morton [this message]
2006-05-14 10:42 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060514025838.0a7a846f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ambx1@neo.rr.com \
--cc=jesper.juhl@gmail.com \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®