From: "Jesper Juhl" <jesper.juhl@gmail.com>
To: "Andrew Morton" <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, ambx1@neo.rr.com
Subject: Re: [PATCH][resend] fix resource leak in pnp card_probe()
Date: Sun, 14 May 2006 12:42:24 +0200 [thread overview]
Message-ID: <9a8748490605140342t7fc9acb7n77dbccb2a96e09e4@mail.gmail.com> (raw)
In-Reply-To: <20060514023833.649fde1d.akpm@osdl.org>
On 14/05/06, Andrew Morton <akpm@osdl.org> wrote:
> Jesper Juhl <jesper.juhl@gmail.com> wrote:
> >
> > (resend of patch already send once on 23/03-2006
> > - still applies cleanly to latest -git)
> >
> >
> > We can leak `clink' in drivers/pnp/card.c::card_probe()
> >
[snip]
>
> If !drv->probe then there's not much point in doing the kmalloc and then
> immediately freeing it again.
>
True. It was simply the simplest and least intrusive fix I could make.
> Like this?
>
Looks good to me, thanks.
[snip neater version of fix]
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
prev parent reply other threads:[~2006-05-14 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-13 20:35 Jesper Juhl
2006-05-14 9:38 ` Andrew Morton
2006-05-14 9:48 ` Keith Owens
2006-05-14 9:58 ` Andrew Morton
2006-05-14 10:42 ` Jesper Juhl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8748490605140342t7fc9acb7n77dbccb2a96e09e4@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=akpm@osdl.org \
--cc=ambx1@neo.rr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®