mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Serge E. Hallyn" <serue@us.ibm.com>,
	linux-kernel@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: [PATCH] kthread: convert stop_machine into a kthread
Date: Tue, 20 Jun 2006 20:44:53 -0500	[thread overview]
Message-ID: <20060621014453.GA18821@sergelap.austin.ibm.com> (raw)
In-Reply-To: <20060620181856.df8afa60.akpm@osdl.org>

Quoting Andrew Morton (akpm@osdl.org):
> On Tue, 20 Jun 2006 19:52:06 -0500
> "Serge E. Hallyn" <serue@us.ibm.com> wrote:
> 
> > here's
> > the patch I meant to send.
> > 
> > ...
> >
> > -static int stopmachine(void *cpu)
> > +static int stopmachine(void)
> > ...
> > -		tsk = kthread_run(stopmachine, (void *)(long)i, "stopmachine");
> > +		tsk = kthread_create(stopmachine, NULL, "stopmachine");
> 
> This should have spat a compiler warning.
> 
> The confidence level on all of this ain't high.  Please, test the patch
> which I merged?

Compiles, boots, and shuts down on s390.

thanks,
-serge

  reply	other threads:[~2006-06-21  1:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-15 14:43 Serge E. Hallyn
2006-06-20  3:14 ` Andrew Morton
2006-06-20  3:20   ` Erik Ohrnberger
2006-06-20  8:27   ` Serge E. Hallyn
2006-06-20  8:40     ` Andrew Morton
2006-06-20 16:27       ` Serge E. Hallyn
2006-06-20 22:42         ` Andrew Morton
2006-06-21  0:52           ` Serge E. Hallyn
2006-06-21  1:18             ` Andrew Morton
2006-06-21  1:44               ` Serge E. Hallyn [this message]
2006-06-21  3:15       ` [PATCH] kthread: move kernel-doc and put it into DocBook Randy.Dunlap
     [not found] <17553.56625.612931.136018@cargo.ozlabs.ibm.com>
2006-06-16  1:04 ` [PATCH] kthread: convert stop_machine into a kthread Rusty Russell
2006-06-16  3:04   ` Serge E. Hallyn
2006-06-16  3:54     ` Paul Mackerras
2006-06-16  4:00     ` Rusty Russell
2006-06-16 12:54       ` Serge E. Hallyn
2006-06-18 12:12         ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060621014453.GA18821@sergelap.austin.ibm.com \
    --to=serue@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®