* [PATCH] Fix warning in do_IRQ (i386)
@ 2006-06-26 21:08 Jean Delvare
2006-06-26 21:55 ` Björn Steinbrink
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2006-06-26 21:08 UTC (permalink / raw)
To: LKML; +Cc: Björn Steinbrink, Arjan van de Ven
arch/i386/kernel/irq.c: In function `do_IRQ':
arch/i386/kernel/irq.c:104: warning: suggest parentheses around arithmetic in operand of |
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Björn Steinbrink <B.Steinbrink@gmx.de>
Cc: Arjan van de Ven <arjan@linux.intel.com>
---
arch/i386/kernel/irq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.17-git.orig/arch/i386/kernel/irq.c 2006-06-26 21:55:03.000000000 +0200
+++ linux-2.6.17-git/arch/i386/kernel/irq.c 2006-06-26 22:54:49.000000000 +0200
@@ -100,8 +100,8 @@
* softirq checks work in the hardirq context.
*/
irqctx->tinfo.preempt_count =
- irqctx->tinfo.preempt_count & ~SOFTIRQ_MASK |
- curctx->tinfo.preempt_count & SOFTIRQ_MASK;
+ (irqctx->tinfo.preempt_count & ~SOFTIRQ_MASK) |
+ (curctx->tinfo.preempt_count & SOFTIRQ_MASK);
asm volatile(
" xchgl %%ebx,%%esp \n"
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix warning in do_IRQ (i386)
2006-06-26 21:08 [PATCH] Fix warning in do_IRQ (i386) Jean Delvare
@ 2006-06-26 21:55 ` Björn Steinbrink
0 siblings, 0 replies; 2+ messages in thread
From: Björn Steinbrink @ 2006-06-26 21:55 UTC (permalink / raw)
To: Jean Delvare; +Cc: LKML, Arjan van de Ven
On 2006.06.26 23:08:57 +0200, Jean Delvare wrote:
> arch/i386/kernel/irq.c: In function `do_IRQ':
> arch/i386/kernel/irq.c:104: warning: suggest parentheses around arithmetic in operand of |
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Björn Steinbrink <B.Steinbrink@gmx.de>
> Cc: Arjan van de Ven <arjan@linux.intel.com>
> ---
> arch/i386/kernel/irq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2.6.17-git.orig/arch/i386/kernel/irq.c 2006-06-26 21:55:03.000000000 +0200
> +++ linux-2.6.17-git/arch/i386/kernel/irq.c 2006-06-26 22:54:49.000000000 +0200
> @@ -100,8 +100,8 @@
> * softirq checks work in the hardirq context.
> */
> irqctx->tinfo.preempt_count =
> - irqctx->tinfo.preempt_count & ~SOFTIRQ_MASK |
> - curctx->tinfo.preempt_count & SOFTIRQ_MASK;
> + (irqctx->tinfo.preempt_count & ~SOFTIRQ_MASK) |
> + (curctx->tinfo.preempt_count & SOFTIRQ_MASK);
>
> asm volatile(
> " xchgl %%ebx,%%esp \n"
Hi,
thanks for catching that one, I even fixed that on the box where the
patch was tested but then obviously sent the old patch.
Acked-by: Björn Steinbrink <B.Steinbrink@gmx.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-26 21:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-06-26 21:08 [PATCH] Fix warning in do_IRQ (i386) Jean Delvare
2006-06-26 21:55 ` Björn Steinbrink
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®