Re: 2.6.17-mm6

[Andrew Morton <akpm@osdl.org>]

On Mon, 3 Jul 2006 21:36:55 +0100
Alistair John Strachan <s0348365@sms.ed.ac.uk> wrote:

> On Monday 03 July 2006 21:17, Andrew Morton wrote:
> > On Mon, 3 Jul 2006 20:56:28 +0100
> >
> > Alistair John Strachan <s0348365@sms.ed.ac.uk> wrote:
> > > On Monday 03 July 2006 20:39, Andrew Morton wrote:
> > > > On Mon, 3 Jul 2006 20:27:21 +0100
> > > >
> > > > Alistair John Strachan <s0348365@sms.ed.ac.uk> wrote:
> > > > > On Monday 03 July 2006 11:03, Andrew Morton wrote:
> > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.1
> > > > > >7/2. 6.17 -mm6/
> > > > >
> > > > > Doesn't boot reliably as an x86-64 kernel on my X2 system, 3/4 times
> > > > > it oopses horribly. Is there some way to supress an oops flood so I
> > > > > can get a decent picture of it with vga=extended? Right now I get two
> > > > > useless oopses after the first (probably useful) one.
> > > >
> > > > Try adding `pause_on_oops=100000' to the kernel boot command line.
> > >
> > > (Trimmed Nathan)
> > >
> > > Helped somewhat, but I'm still missing a bit at the top.
> > >
> > > http://devzero.co.uk/~alistair/oops-20060703/
> >
> > That is irritating.  This should get us more info:
> 
> Indeed, thanks.
> 
> Try the same URL again, I've uploaded 3,4,5 from a couple of reboots. I still 
> think I'm missing something at the top, but 3 is the earliest I could snap.
> 

Getting better.

It would kinda help if pause_on_oops() was actually implemented on x86_64..

--- a/arch/x86_64/kernel/traps.c~x86_64-wire-up-oops_enter-oops_exit
+++ a/arch/x86_64/kernel/traps.c
@@ -551,11 +551,14 @@ void __kprobes __die(const char * str, s
 
 void die(const char * str, struct pt_regs * regs, long err)
 {
-	unsigned long flags = oops_begin();
+	unsigned long flags;
 
+	oops_enter();
+	flags = oops_begin();
 	handle_BUG(regs);
 	__die(str, regs, err);
 	oops_end(flags);
+	oops_exit();
 	do_exit(SIGSEGV); 
 }
 
_