mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, norsk5@xmission.com
Cc: linux-kernel@vger.kernel.org, bluesmoke-devel@lists.sourceforge.net
Subject: [-mm patch] drivers/edac/: make code static
Date: Thu, 6 Jul 2006 22:36:59 +0200	[thread overview]
Message-ID: <20060706203659.GP26941@stusta.de> (raw)
In-Reply-To: <20060703030355.420c7155.akpm@osdl.org>

This patch makes needlessly global code static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/edac/edac_mc.c |   25 +++++++++++--------------
 drivers/edac/edac_mc.h |    8 --------
 drivers/edac/k8_edac.c |    2 +-
 3 files changed, 12 insertions(+), 23 deletions(-)

--- linux-2.6.17-mm6-full/drivers/edac/edac_mc.h.old	2006-07-06 19:31:37.000000000 +0200
+++ linux-2.6.17-mm6-full/drivers/edac/edac_mc.h	2006-07-06 19:32:43.000000000 +0200
@@ -406,19 +406,11 @@
 
 #endif /* CONFIG_PCI */
 
-#ifdef CONFIG_EDAC_DEBUG
-void edac_mc_dump_channel(struct channel_info *chan);
-void edac_mc_dump_mci(struct mem_ctl_info *mci);
-void edac_mc_dump_csrow(struct csrow_info *csrow);
-#endif  /* CONFIG_EDAC_DEBUG */
-
 extern struct mem_ctl_info * edac_mc_find(int idx);
 extern int edac_mc_add_mc(struct mem_ctl_info *mci,int mc_idx);
 extern struct mem_ctl_info * edac_mc_del_mc(struct device *dev);
 extern int edac_mc_find_csrow_by_page(struct mem_ctl_info *mci,
 					unsigned long page);
-extern void edac_mc_scrub_block(unsigned long page, unsigned long offset,
-		u32 size);
 
 /*
  * The no info errors are used when error overflows are reported.
--- linux-2.6.17-mm6-full/drivers/edac/edac_mc.c.old	2006-07-06 18:43:39.000000000 +0200
+++ linux-2.6.17-mm6-full/drivers/edac/edac_mc.c	2006-07-06 19:33:01.000000000 +0200
@@ -177,7 +177,7 @@
 };
 
 #define MEMCTRL_ATTR(_name,_mode,_show,_store)			\
-struct memctrl_dev_attribute attr_##_name = {			\
+static struct memctrl_dev_attribute attr_##_name = {			\
 	.attr = {.name = __stringify(_name), .mode = _mode },	\
 	.value  = &_name,					\
 	.show   = _show,					\
@@ -185,7 +185,7 @@
 };
 
 #define MEMCTRL_STRING_ATTR(_name,_data,_mode,_show,_store)	\
-struct memctrl_dev_attribute attr_##_name = {			\
+static struct memctrl_dev_attribute attr_##_name = {			\
 	.attr = {.name = __stringify(_name), .mode = _mode },	\
 	.value  = _data,					\
 	.show   = _show,					\
@@ -333,7 +333,7 @@
 };
 
 #define EDAC_PCI_ATTR(_name,_mode,_show,_store)			\
-struct edac_pci_dev_attribute edac_pci_attr_##_name = {		\
+static struct edac_pci_dev_attribute edac_pci_attr_##_name = {		\
 	.attr = {.name = __stringify(_name), .mode = _mode },	\
 	.value  = &_name,					\
 	.show   = _show,					\
@@ -341,7 +341,7 @@
 };
 
 #define EDAC_PCI_STRING_ATTR(_name,_data,_mode,_show,_store)	\
-struct edac_pci_dev_attribute edac_pci_attr_##_name = {		\
+static struct edac_pci_dev_attribute edac_pci_attr_##_name = {		\
 	.attr = {.name = __stringify(_name), .mode = _mode },	\
 	.value  = _data,					\
 	.show   = _show,					\
@@ -712,7 +712,7 @@
 };
 
 #define CSROWDEV_ATTR(_name,_mode,_show,_store,_private)	\
-struct csrowdev_attribute attr_##_name = {			\
+static struct csrowdev_attribute attr_##_name = {			\
 	.attr = {.name = __stringify(_name), .mode = _mode },	\
 	.show   = _show,					\
 	.store  = _store,					\
@@ -1005,7 +1005,7 @@
 };
 
 #define MCIDEV_ATTR(_name,_mode,_show,_store)			\
-struct mcidev_attribute mci_attr_##_name = {			\
+static struct mcidev_attribute mci_attr_##_name = {			\
 	.attr = {.name = __stringify(_name), .mode = _mode },	\
 	.show   = _show,					\
 	.store  = _store,					\
@@ -1155,7 +1155,7 @@
 
 #ifdef CONFIG_EDAC_DEBUG
 
-void edac_mc_dump_channel(struct channel_info *chan)
+static void edac_mc_dump_channel(struct channel_info *chan)
 {
 	debugf4("\tchannel = %p\n", chan);
 	debugf4("\tchannel->chan_idx = %d\n", chan->chan_idx);
@@ -1163,9 +1163,8 @@
 	debugf4("\tchannel->label = '%s'\n", chan->label);
 	debugf4("\tchannel->csrow = %p\n\n", chan->csrow);
 }
-EXPORT_SYMBOL_GPL(edac_mc_dump_channel);
 
-void edac_mc_dump_csrow(struct csrow_info *csrow)
+static void edac_mc_dump_csrow(struct csrow_info *csrow)
 {
 	debugf4("\tcsrow = %p\n", csrow);
 	debugf4("\tcsrow->csrow_idx = %d\n", csrow->csrow_idx);
@@ -1179,9 +1178,8 @@
 	debugf4("\tcsrow->channels = %p\n", csrow->channels);
 	debugf4("\tcsrow->mci = %p\n\n", csrow->mci);
 }
-EXPORT_SYMBOL_GPL(edac_mc_dump_csrow);
 
-void edac_mc_dump_mci(struct mem_ctl_info *mci)
+static void edac_mc_dump_mci(struct mem_ctl_info *mci)
 {
 	debugf3("\tmci = %p\n", mci);
 	debugf3("\tmci->mtype_cap = %lx\n", mci->mtype_cap);
@@ -1195,7 +1193,6 @@
 		mci->mod_name, mci->ctl_name);
 	debugf3("\tpvt_info = %p\n\n", mci->pvt_info);
 }
-EXPORT_SYMBOL_GPL(edac_mc_dump_mci);
 
 #endif  /* CONFIG_EDAC_DEBUG */
 
@@ -1511,7 +1508,8 @@
 }
 EXPORT_SYMBOL_GPL(edac_mc_del_mc);
 
-void edac_mc_scrub_block(unsigned long page, unsigned long offset, u32 size)
+static void edac_mc_scrub_block(unsigned long page, unsigned long offset,
+				u32 size)
 {
 	struct page *pg;
 	void *virt_addr;
@@ -1540,7 +1538,6 @@
 	if (PageHighMem(pg))
 		local_irq_restore(flags);
 }
-EXPORT_SYMBOL_GPL(edac_mc_scrub_block);
 
 /* FIXME - should return -1 */
 int edac_mc_find_csrow_by_page(struct mem_ctl_info *mci, unsigned long page)
--- linux-2.6.17-mm6-full/drivers/edac/k8_edac.c.old	2006-07-06 19:33:15.000000000 +0200
+++ linux-2.6.17-mm6-full/drivers/edac/k8_edac.c	2006-07-06 19:33:39.000000000 +0200
@@ -1864,7 +1864,7 @@
 	.id_table = k8_pci_tbl,
 };
 
-int __init k8_init(void)
+static int __init k8_init(void)
 {
 	return pci_module_init(&k8_driver);
 }


  parent reply	other threads:[~2006-07-06 20:37 UTC|newest]

Thread overview: 126+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-03 10:03 2.6.17-mm6 Andrew Morton
2006-07-03 10:50 ` 2.6.17-mm6 Michal Piotrowski
2006-07-03 10:56   ` 2.6.17-mm6 Andrew Morton
2006-07-03 11:36     ` 2.6.17-mm6 Michal Piotrowski
2006-07-03 12:27       ` 2.6.17-mm6 Michal Piotrowski
2006-07-03 13:28         ` 2.6.17-mm6 Dmitry Torokhov
2006-07-03 11:00 ` 2.6.17-mm6 Reuben Farrelly
2006-07-03 11:25   ` 2.6.17-mm6 Andrew Morton
2006-07-03 12:34     ` 2.6.17-mm6 Reuben Farrelly
2006-07-03 11:39   ` 2.6.17-mm6 Andrew Morton
2006-07-03 11:41     ` 2.6.17-mm6 Reuben Farrelly
2006-07-03 12:10       ` 2.6.17-mm6 Andrew Morton
2006-07-03 13:36         ` 2.6.17-mm6 Reuben Farrelly
2006-07-03 20:21       ` 2.6.17-mm6 Andrew Morton
2006-07-03 20:31         ` 2.6.17-mm6 Reuben Farrelly
2006-07-03 12:29   ` 2.6.17-mm6 Sergey Vlasov
2006-07-03 17:25     ` 2.6.17-mm6 Jeremy Fitzhardinge
2006-07-03 19:01       ` 2.6.17-mm6 Andrew Morton
2006-07-03 12:15 ` 2.6.17-mm6 Cedric Le Goater
2006-07-03 12:17   ` 2.6.17-mm6 Heiko Carstens
2006-07-03 13:08     ` 2.6.17-mm6 Martin Peschke
2006-07-03 13:12     ` 2.6.17-mm6 Cedric Le Goater
2006-07-03 12:15 ` 2.6.17-mm6 Cedric Le Goater
2006-07-03 14:09   ` 2.6.17-mm6 Theodore Tso
2006-07-03 19:07 ` 2.6.17-mm6 Alistair John Strachan
2006-07-03 19:37   ` 2.6.17-mm6 Andrew Morton
2006-07-03 19:43     ` 2.6.17-mm6 Alistair John Strachan
2006-07-03 19:27 ` 2.6.17-mm6 Alistair John Strachan
2006-07-03 19:39   ` 2.6.17-mm6 Andrew Morton
2006-07-03 19:56     ` 2.6.17-mm6 Alistair John Strachan
2006-07-03 20:17       ` 2.6.17-mm6 Andrew Morton
2006-07-03 20:36         ` 2.6.17-mm6 Alistair John Strachan
2006-07-03 20:54           ` 2.6.17-mm6 Andrew Morton
2006-07-03 21:50             ` 2.6.17-mm6 Alistair John Strachan
2006-07-03 23:31               ` 2.6.17-mm6 Andrew Morton
2006-07-04  8:34                 ` 2.6.17-mm6 Alistair John Strachan
2006-07-04  8:49                   ` 2.6.17-mm6 Andrew Morton
2006-07-04 16:28                     ` 2.6.17-mm6 Alistair John Strachan
2006-07-05 20:37                     ` 2.6.17-mm6 john stultz
2006-07-05 20:46                       ` 2.6.17-mm6 Greg KH
2006-07-05 22:32                         ` 2.6.17-mm6 Alistair John Strachan
2006-07-06 17:31                           ` 2.6.17-mm6 john stultz
2006-07-06 19:06                             ` 2.6.17-mm6 Alistair John Strachan
2006-07-06 19:16                               ` 2.6.17-mm6 Alistair John Strachan
2006-07-06 20:02                             ` 2.6.17-mm6 Alistair John Strachan
2006-07-06 20:11                               ` 2.6.17-mm6 Greg KH
2006-07-07 20:48                                 ` 2.6.17-mm6 Alistair John Strachan
2006-07-08 16:02                                   ` 2.6.17-mm6 Alistair John Strachan
2006-07-03 22:10             ` 2.6.17-mm6 Anton Blanchard
2006-07-04 19:53 ` 2.6.17-mm6 Rafael J. Wysocki
2006-07-04 20:01   ` 2.6.17-mm6 Arjan van de Ven
2006-07-05 10:27     ` 2.6.17-mm6 Stefan Richter
2006-07-05 10:36       ` 2.6.17-mm6 Stefan Richter
2006-07-05 11:13         ` 2.6.17-mm6 Ingo Molnar
2006-07-05 21:43 ` 2.6.17-mm6 J.A. Magallón
2006-07-05 22:56   ` 2.6.17-mm6 Andrew Morton
2006-07-05 23:57     ` 2.6.17-mm6 J.A. Magallón
2006-07-06  0:02       ` 2.6.17-mm6 Andrew Morton
2006-07-06 14:36         ` 2.6.17-mm6 J.A. Magallón
2006-07-06 14:48           ` 2.6.17-mm6 J.A. Magallón
2006-07-06 21:44             ` 2.6.17-mm6 J.A. Magallón
2006-07-06 21:57               ` 2.6.17-mm6 Andrew Morton
2006-07-07 15:38                 ` 2.6.17-mm6 J.A. Magallón
2006-07-07 16:02                 ` 2.6.17-mm6 Alan Cox
2006-07-07 15:55                   ` 2.6.17-mm6 J.A. Magallón
2006-07-07 16:44                     ` 2.6.17-mm6 Alan Cox
2006-07-07 16:34                       ` 2.6.17-mm6 Randy.Dunlap
2006-07-07 17:09                         ` 2.6.17-mm6 Alan Cox
2006-07-07 17:14                           ` 2.6.17-mm6 Jeff Garzik
2006-07-07 17:22                             ` 2.6.17-mm6 David Lloyd
2006-07-07 17:23                               ` 2.6.17-mm6 Jeff Garzik
2006-07-07 17:44                             ` 2.6.17-mm6 Alan Cox
2006-07-07 17:39                               ` 2.6.17-mm6 Jeff Garzik
2006-07-07 20:03                                 ` 2.6.17-mm6 Alan Cox
2006-07-07 19:59                                   ` 2.6.17-mm6 Jeff Garzik
2006-07-07 20:23                                     ` 2.6.17-mm6 Alan Cox
2006-07-07 20:14                                       ` 2.6.17-mm6 Jeff Garzik
2006-07-07 20:42                                         ` 2.6.17-mm6 Alan Cox
2006-07-07 20:37                                           ` 2.6.17-mm6 Jeff Garzik
2006-07-07 21:09                                             ` 2.6.17-mm6 J.A. Magallón
2006-07-07 21:11                                               ` 2.6.17-mm6 Jeff Garzik
2006-07-07 21:40                                                 ` 2.6.17-mm6 J.A. Magallón
2006-07-06 23:26               ` 2.6.17-mm6 (try-3) Randy.Dunlap
     [not found] ` <a762e240607051447x3c3c6e15k9cdb38804cf13f35@mail.gmail.com>
2006-07-05 22:50   ` 2.6.17-mm6 Andrew Morton
2006-07-05 23:28     ` 2.6.17-mm6 Keith Mannthey
2006-07-05 23:44       ` 2.6.17-mm6 Andrew Morton
2006-07-05 23:48         ` 2.6.17-mm6 Andrew Morton
2006-07-06  0:05           ` 2.6.17-mm6 Keith Mannthey
2006-07-06  0:25             ` 2.6.17-mm6 Andrew Morton
2006-07-06  5:42               ` 2.6.17-mm6 Eric W. Biederman
2006-07-06  5:59                 ` 2.6.17-mm6 Andrew Morton
2006-07-06  6:31                   ` 2.6.17-mm6 Andrew Morton
2006-07-06  7:18                     ` 2.6.17-mm6 Eric W. Biederman
2006-07-06  7:25                       ` 2.6.17-mm6 Ingo Molnar
2006-07-06  8:21                         ` 2.6.17-mm6 Eric W. Biederman
2006-07-06  8:26                           ` 2.6.17-mm6 Ingo Molnar
2006-07-06  7:31                       ` 2.6.17-mm6 Arjan van de Ven
2006-07-06 16:37                         ` 2.6.17-mm6 Valdis.Kletnieks
2006-07-06 16:49                     ` 2.6.17-mm6 Eric W. Biederman
2006-07-06  6:40                   ` 2.6.17-mm6 Eric W. Biederman
2006-07-06  7:38                   ` 2.6.17-mm6 vmstat breakage Mike Galbraith
2006-07-06  8:24                     ` Andrew Morton
2006-07-06 17:16                 ` 2.6.17-mm6 Andi Kleen
2006-07-12  3:55               ` 2.6.17-mm6 Steven Rostedt
2006-07-06 20:36 ` Adrian Bunk [this message]
2006-07-06 20:37 ` [-mm patch] fs/ocfs2/inode.c:ocfs2_refresh_inode(): remove unused variable Adrian Bunk
2006-07-06 20:43   ` Mark Fasheh
2006-07-06 20:37 ` [-mm patch] reiserfs: warn about the useless nolargeio option Adrian Bunk
2006-07-07  0:35   ` Hans Reiser
2006-07-06 20:37 ` [-mm patch] drivers/net/e1000/: possible cleanups Adrian Bunk
2006-07-06 20:47   ` Auke Kok
2006-07-07  7:35     ` Adrian Bunk
2006-07-07  9:17 ` 2.6.17-mm6 Reuben Farrelly
2006-07-07  9:35   ` 2.6.17-mm6 Andrew Morton
2006-07-07 21:15     ` 2.6.17-mm6 Reuben Farrelly
2006-07-07 21:38       ` 2.6.17-mm6 Andrew Morton
2006-07-07 21:42         ` 2.6.17-mm6 Martin Bligh
2006-07-07 23:06           ` 2.6.17-mm6 Andrew Morton
2006-07-08  3:46           ` 2.6.17-mm6 Badari Pulavarty
2006-07-07 23:08         ` 2.6.17-mm6 Reuben Farrelly
2006-07-07 15:24 ` 2.6.17-mm6 Reuben Farrelly
2006-07-08 20:20 ` 2.6.17-mm6: kernel/sysctl.c: PROC_FS=n compile error Adrian Bunk
2006-07-09 18:52   ` Serge E. Hallyn
2006-07-09 23:33     ` Adrian Bunk
2006-07-10 14:22       ` Serge E. Hallyn
2006-07-10 15:08       ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060706203659.GP26941@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=bluesmoke-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=norsk5@xmission.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome