Compile Error on 2.6.17-mm6

Compile Error on 2.6.17-mm6

[Matt Reuther]

[-- Attachment #1: Type: text/plain, Size: 748 bytes --]

I tried compiling the 2.6.17-mm6 kernel twice, and got the same error both 
times.

Here is the error:
  CHK     include/linux/compile.h
  UPD     include/linux/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1
arch/i386/kernel/built-in.o(.text+0xe282): In function 
`cpu_request_microcode':
arch/i386/kernel/microcode.c:544: undefined reference to `request_firmware'
arch/i386/kernel/built-in.o(.text+0xe304):arch/i386/kernel/microcode.c:573: 
undefined reference to `release_firmware'
make: *** [.tmp_vmlinux1] Error 1

I can send the entire compile log if you need it.

I attached the config. I am compiling this on a Slackware 10.2 system, with 
gcc-3.3.6 and make 3.80
-- 
Matt Reuther

[-- Attachment #2.1: config-2.6.17-mm6.bz2 --]
[-- Type: application/x-bzip2, Size: 14269 bytes --]

[-- Attachment #2.2: Type: application/pgp-signature, Size: 189 bytes --]

Re: Compile Error on 2.6.17-mm6

[Andrew Morton]

On Fri, 7 Jul 2006 22:22:16 -0400
Matt Reuther <mreuther@umich.edu> wrote:

> Here is the error:
>   CHK     include/linux/compile.h
>   UPD     include/linux/compile.h
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> arch/i386/kernel/built-in.o(.text+0xe282): In function 
> `cpu_request_microcode':
> arch/i386/kernel/microcode.c:544: undefined reference to `request_firmware'
> arch/i386/kernel/built-in.o(.text+0xe304):arch/i386/kernel/microcode.c:573: 
> undefined reference to `release_firmware'

CONFIG_FW_LOADER=m
CONFIG_MICROCODE=y

So

config MICROCODE
	tristate "/dev/cpu/microcode - Intel IA32 CPU microcode support"
	depends on FW_LOADER

is not sufficient.  There's a fix for this, but I cannot remember what it
is.  Help.

Re: Compile Error on 2.6.17-mm6

[Randy.Dunlap]

On Sat, 8 Jul 2006 17:43:47 -0700 Andrew Morton wrote:

> On Fri, 7 Jul 2006 22:22:16 -0400
> Matt Reuther <mreuther@umich.edu> wrote:
> 
> > Here is the error:
> >   CHK     include/linux/compile.h
> >   UPD     include/linux/compile.h
> >   CC      init/version.o
> >   LD      init/built-in.o
> >   LD      .tmp_vmlinux1
> > arch/i386/kernel/built-in.o(.text+0xe282): In function 
> > `cpu_request_microcode':
> > arch/i386/kernel/microcode.c:544: undefined reference to `request_firmware'
> > arch/i386/kernel/built-in.o(.text+0xe304):arch/i386/kernel/microcode.c:573: 
> > undefined reference to `release_firmware'
> 
> CONFIG_FW_LOADER=m
> CONFIG_MICROCODE=y
> 
> So
> 
> config MICROCODE
> 	tristate "/dev/cpu/microcode - Intel IA32 CPU microcode support"
> 	depends on FW_LOADER
> 
> is not sufficient.  There's a fix for this, but I cannot remember what it
> is.  Help.

That 1-line depends patch fixes the problem for me (on x86-64,
but they are the same in this area).

---
~Randy

Re: Compile Error on 2.6.17-mm6

[Andrew Morton]

On Sat, 8 Jul 2006 20:34:24 -0700
"Randy.Dunlap" <rdunlap@xenotime.net> wrote:

> On Sat, 8 Jul 2006 17:43:47 -0700 Andrew Morton wrote:
> 
> > On Fri, 7 Jul 2006 22:22:16 -0400
> > Matt Reuther <mreuther@umich.edu> wrote:
> > 
> > > Here is the error:
> > >   CHK     include/linux/compile.h
> > >   UPD     include/linux/compile.h
> > >   CC      init/version.o
> > >   LD      init/built-in.o
> > >   LD      .tmp_vmlinux1
> > > arch/i386/kernel/built-in.o(.text+0xe282): In function 
> > > `cpu_request_microcode':
> > > arch/i386/kernel/microcode.c:544: undefined reference to `request_firmware'
> > > arch/i386/kernel/built-in.o(.text+0xe304):arch/i386/kernel/microcode.c:573: 
> > > undefined reference to `release_firmware'
> > 
> > CONFIG_FW_LOADER=m
> > CONFIG_MICROCODE=y
> > 
> > So
> > 
> > config MICROCODE
> > 	tristate "/dev/cpu/microcode - Intel IA32 CPU microcode support"
> > 	depends on FW_LOADER
> > 
> > is not sufficient.  There's a fix for this, but I cannot remember what it
> > is.  Help.
> 
> That 1-line depends patch fixes the problem for me (on x86-64,
> but they are the same in this area).
> 

What patch is that?

Re: Compile Error on 2.6.17-mm6

[Randy.Dunlap]

On Sat, 8 Jul 2006 20:44:48 -0700 Andrew Morton wrote:

> On Sat, 8 Jul 2006 20:34:24 -0700
> "Randy.Dunlap" <rdunlap@xenotime.net> wrote:
> 
> > On Sat, 8 Jul 2006 17:43:47 -0700 Andrew Morton wrote:
> > 
> > > On Fri, 7 Jul 2006 22:22:16 -0400
> > > Matt Reuther <mreuther@umich.edu> wrote:
> > > 
> > > > Here is the error:
> > > >   CHK     include/linux/compile.h
> > > >   UPD     include/linux/compile.h
> > > >   CC      init/version.o
> > > >   LD      init/built-in.o
> > > >   LD      .tmp_vmlinux1
> > > > arch/i386/kernel/built-in.o(.text+0xe282): In function 
> > > > `cpu_request_microcode':
> > > > arch/i386/kernel/microcode.c:544: undefined reference to `request_firmware'
> > > > arch/i386/kernel/built-in.o(.text+0xe304):arch/i386/kernel/microcode.c:573: 
> > > > undefined reference to `release_firmware'
> > > 
> > > CONFIG_FW_LOADER=m
> > > CONFIG_MICROCODE=y
> > > 
> > > So
> > > 
> > > config MICROCODE
> > > 	tristate "/dev/cpu/microcode - Intel IA32 CPU microcode support"
> > > 	depends on FW_LOADER
> > > 
> > > is not sufficient.  There's a fix for this, but I cannot remember what it
> > > is.  Help.
> > 
> > That 1-line depends patch fixes the problem for me (on x86-64,
> > but they are the same in this area).
> > 
> 
> What patch is that?

My -mm6 does not have "depends on FW_LOADER" like you wrote above,
so I thought that you had added that 1-line as a patch.



From: Randy Dunlap <rdunlap@xenotime.net>

MICROCODE needs FW_LOADER functions.

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
 arch/i386/Kconfig   |    1 +
 arch/x86_64/Kconfig |    1 +
 2 files changed, 2 insertions(+)

--- linux-2617-mm6.orig/arch/x86_64/Kconfig
+++ linux-2617-mm6/arch/x86_64/Kconfig
@@ -159,6 +159,7 @@ config X86_GOOD_APIC
 
 config MICROCODE
 	tristate "/dev/cpu/microcode - Intel CPU microcode support"
+	depends on FW_LOADER
 	---help---
 	  If you say Y here the 'File systems' section, you will be
 	  able to update the microcode on Intel processors. You will
--- linux-2617-mm6.orig/arch/i386/Kconfig
+++ linux-2617-mm6/arch/i386/Kconfig
@@ -399,6 +399,7 @@ config X86_REBOOTFIXUPS
 
 config MICROCODE
 	tristate "/dev/cpu/microcode - Intel IA32 CPU microcode support"
+	depends on FW_LOADER
 	---help---
 	  If you say Y here and also to "/dev file system support" in the
 	  'File systems' section, you will be able to update the microcode on



---

Re: Compile Error on 2.6.17-mm6

[Andrew Morton]

On Sat, 8 Jul 2006 21:37:34 -0700
"Randy.Dunlap" <rdunlap@xenotime.net> wrote:

> On Sat, 8 Jul 2006 20:44:48 -0700 Andrew Morton wrote:
> 
> > On Sat, 8 Jul 2006 20:34:24 -0700
> > "Randy.Dunlap" <rdunlap@xenotime.net> wrote:
> > 
> > > On Sat, 8 Jul 2006 17:43:47 -0700 Andrew Morton wrote:
> > > 
> > > > On Fri, 7 Jul 2006 22:22:16 -0400
> > > > Matt Reuther <mreuther@umich.edu> wrote:
> > > > 
> > > > > Here is the error:
> > > > >   CHK     include/linux/compile.h
> > > > >   UPD     include/linux/compile.h
> > > > >   CC      init/version.o
> > > > >   LD      init/built-in.o
> > > > >   LD      .tmp_vmlinux1
> > > > > arch/i386/kernel/built-in.o(.text+0xe282): In function 
> > > > > `cpu_request_microcode':
> > > > > arch/i386/kernel/microcode.c:544: undefined reference to `request_firmware'
> > > > > arch/i386/kernel/built-in.o(.text+0xe304):arch/i386/kernel/microcode.c:573: 
> > > > > undefined reference to `release_firmware'
> > > > 
> > > > CONFIG_FW_LOADER=m
> > > > CONFIG_MICROCODE=y
> > > > 
> > > > So
> > > > 
> > > > config MICROCODE
> > > > 	tristate "/dev/cpu/microcode - Intel IA32 CPU microcode support"
> > > > 	depends on FW_LOADER
> > > > 
> > > > is not sufficient.  There's a fix for this, but I cannot remember what it
> > > > is.  Help.
> > > 
> > > That 1-line depends patch fixes the problem for me (on x86-64,
> > > but they are the same in this area).
> > > 
> > 
> > What patch is that?
> 
> My -mm6 does not have "depends on FW_LOADER" like you wrote above,
> so I thought that you had added that 1-line as a patch.
> 

Oh, OK, yes, I fixed that post-2.6.17-mm6.

>  arch/x86_64/Kconfig |    1 +

Although I missed x86_64.

Re: Compile Error on 2.6.17-mm6

[Matt Reuther]

On Sunday 09 July 2006 12:37 am, Randy.Dunlap wrote:

> From: Randy Dunlap <rdunlap@xenotime.net>
>
> MICROCODE needs FW_LOADER functions.
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
>  arch/i386/Kconfig   |    1 +
>  arch/x86_64/Kconfig |    1 +
>  2 files changed, 2 insertions(+)
>
> --- linux-2617-mm6.orig/arch/x86_64/Kconfig
> +++ linux-2617-mm6/arch/x86_64/Kconfig
> @@ -159,6 +159,7 @@ config X86_GOOD_APIC
>
>  config MICROCODE
>  	tristate "/dev/cpu/microcode - Intel CPU microcode support"
> +	depends on FW_LOADER
>  	---help---
>  	  If you say Y here the 'File systems' section, you will be
>  	  able to update the microcode on Intel processors. You will
> --- linux-2617-mm6.orig/arch/i386/Kconfig
> +++ linux-2617-mm6/arch/i386/Kconfig
> @@ -399,6 +399,7 @@ config X86_REBOOTFIXUPS
>
>  config MICROCODE
>  	tristate "/dev/cpu/microcode - Intel IA32 CPU microcode support"
> +	depends on FW_LOADER
>  	---help---
>  	  If you say Y here and also to "/dev file system support" in the
>  	  'File systems' section, you will be able to update the microcode on

This fixes the error. Thanks for your help!
Matt

Re: Compile Error on 2.6.17-mm6

[Adrian Bunk]

On Sat, Jul 08, 2006 at 05:43:47PM -0700, Andrew Morton wrote:
> On Fri, 7 Jul 2006 22:22:16 -0400
> Matt Reuther <mreuther@umich.edu> wrote:
> 
> > Here is the error:
> >   CHK     include/linux/compile.h
> >   UPD     include/linux/compile.h
> >   CC      init/version.o
> >   LD      init/built-in.o
> >   LD      .tmp_vmlinux1
> > arch/i386/kernel/built-in.o(.text+0xe282): In function 
> > `cpu_request_microcode':
> > arch/i386/kernel/microcode.c:544: undefined reference to `request_firmware'
> > arch/i386/kernel/built-in.o(.text+0xe304):arch/i386/kernel/microcode.c:573: 
> > undefined reference to `release_firmware'
> 
> CONFIG_FW_LOADER=m
> CONFIG_MICROCODE=y
> 
> So
> 
> config MICROCODE
> 	tristate "/dev/cpu/microcode - Intel IA32 CPU microcode support"
> 	depends on FW_LOADER
> 
> is not sufficient.

This should be sufficient and prevent the above problem (it was only a 
problem if MICROCODE was a bool).

> There's a fix for this, but I cannot remember what it
> is.  Help.

The above dependency is technically correct, but since FW_LOADER is only 
an internal helper variable the more user friendly solution is:

config MICROCODE
	tristate "/dev/cpu/microcode - Intel IA32 CPU microcode support"
	select FW_LOADER

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed