From: Andrew Morton <akpm@osdl.org>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: serue@us.ibm.com, hugh@veritas.com, torvalds@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: please revert kthread from loop.c
Date: Thu, 13 Jul 2006 02:38:29 -0700 [thread overview]
Message-ID: <20060713023829.c19881be.akpm@osdl.org> (raw)
In-Reply-To: <20060712230228.GA19656@sergelap.austin.ibm.com>
On Wed, 12 Jul 2006 18:02:29 -0500
"Serge E. Hallyn" <serue@us.ibm.com> wrote:
> + if (lo->lo_state == Lo_rundown) {
> + spin_unlock_irq(&lo->lo_lock);
> + while (!kthread_should_stop());
eww.
A schedule_timeout_uninterruptible(1) or even cpu_relax() would be less
sinful, but still unpleasant.
It's strange that the problem of kthread_stop(already_exitted_task) hasn't
occurred before.
Again: why is this so hard? It shouldn't be. Perhaps because loop is
using completions in bizarre ways where it should be using
wake_up_process(), wait_event(), etc.
next prev parent reply other threads:[~2006-07-13 9:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-26 18:39 Hugh Dickins
2006-06-27 5:46 ` Serge E. Hallyn
2006-06-28 18:41 ` Hugh Dickins
2006-06-28 19:08 ` Serge E. Hallyn
2006-07-11 19:49 ` Serge E. Hallyn
2006-07-12 0:17 ` Andrew Morton
2006-07-12 3:26 ` Serge E. Hallyn
2006-07-12 3:46 ` Andrew Morton
2006-07-12 14:31 ` Serge E. Hallyn
2006-07-12 23:02 ` Serge E. Hallyn
2006-07-13 9:38 ` Andrew Morton [this message]
2006-07-13 13:36 ` Serge E. Hallyn
2006-07-13 14:57 ` Andrew Morton
2006-07-20 17:00 ` Serge E. Hallyn
2006-07-12 15:13 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060713023829.c19881be.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®