From: Hugh Dickins <hugh@veritas.com>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: please revert kthread from loop.c
Date: Wed, 12 Jul 2006 16:13:35 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0607121602120.13239@blonde.wat.veritas.com> (raw)
In-Reply-To: <20060711194932.GA27176@sergelap.austin.ibm.com>
On Tue, 11 Jul 2006, Serge E. Hallyn wrote:
> > But not good for me. Gets further e.g. 170 iterations,
> > but then hangs while kthread_stop waits for completion.
>
> After getting much more familiar with the code, here is a more invasive,
> but pretty heavily tested patch.
I didn't study your patch in detail: as you say, more invasive,
but if it really does the job then it's an improvement, removing
some mystery from loop_thread(). And it does work fine for me -
well, I tested with your next little race addition, and Andrew's
on top of that (with lo->state typo fixed to lo->lo_state); but
I haven't tried your latest refinement from today.
Thanks,
Hugh
prev parent reply other threads:[~2006-07-12 15:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-26 18:39 Hugh Dickins
2006-06-27 5:46 ` Serge E. Hallyn
2006-06-28 18:41 ` Hugh Dickins
2006-06-28 19:08 ` Serge E. Hallyn
2006-07-11 19:49 ` Serge E. Hallyn
2006-07-12 0:17 ` Andrew Morton
2006-07-12 3:26 ` Serge E. Hallyn
2006-07-12 3:46 ` Andrew Morton
2006-07-12 14:31 ` Serge E. Hallyn
2006-07-12 23:02 ` Serge E. Hallyn
2006-07-13 9:38 ` Andrew Morton
2006-07-13 13:36 ` Serge E. Hallyn
2006-07-13 14:57 ` Andrew Morton
2006-07-20 17:00 ` Serge E. Hallyn
2006-07-12 15:13 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0607121602120.13239@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®