mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: "Serge E. Hallyn" <serue@us.ibm.com>,
	Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: please revert kthread from loop.c
Date: Mon, 26 Jun 2006 19:39:23 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0606261920440.1330@blonde.wat.veritas.com> (raw)

Please revert c7b2eff059fcc2d1b7085ee3d84b79fd657a537b
[PATCH] kthread: update loop.c to use kthread

It seems too little tested: "losetup -d /dev/loop0" fails with
EINVAL because nothing sets lo_thread; but even when you patch
loop_thread() to set lo->lo_thread = current, it can't survive
more than a few dozen iterations of the loop below (with a tmpfs
mounted on /tst): collapses with failed ioctl then BUG_ON(!bio).
I think the original lo_done completion was more subtle and safe
than the kthread conversion has allowed for.

j=0
cp /dev/zero /tst
while :
do
	let j=j+1
	echo "Doing pass $j"
	losetup /dev/loop0 /tst/zero
	mkfs -t ext2 -b 1024 /dev/loop0 >/dev/null 2>&1
	mount -t ext2 /dev/loop0 /mnt
	umount /mnt
	losetup -d /dev/loop0
done

             reply	other threads:[~2006-06-26 18:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-26 18:39 Hugh Dickins [this message]
2006-06-27  5:46 ` Serge E. Hallyn
2006-06-28 18:41   ` Hugh Dickins
2006-06-28 19:08     ` Serge E. Hallyn
2006-07-11 19:49     ` Serge E. Hallyn
2006-07-12  0:17       ` Andrew Morton
2006-07-12  3:26         ` Serge E. Hallyn
2006-07-12  3:46           ` Andrew Morton
2006-07-12 14:31             ` Serge E. Hallyn
2006-07-12 23:02             ` Serge E. Hallyn
2006-07-13  9:38               ` Andrew Morton
2006-07-13 13:36                 ` Serge E. Hallyn
2006-07-13 14:57                   ` Andrew Morton
2006-07-20 17:00                     ` Serge E. Hallyn
2006-07-12 15:13       ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0606261920440.1330@blonde.wat.veritas.com \
    --to=hugh@veritas.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=serue@us.ibm.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®