[PATCH]drivers: returning proper error from serial driver

[PATCH]drivers: returning proper error from serial driver

[Ram Gupta]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

This patch fixes the issue of returning 0 even in case of error from
uart_set_info function.
Now it returns the  error EBUSY  when it can not set new port. Please apply

Signed-off-by: Ram Gupta(r.gupta@astronautics.com)
-------------
Thanks
Ram Gupta

[-- Attachment #2: patch.serial_core --]
[-- Type: application/octet-stream, Size: 359 bytes --]

--- linux-2.6.17/drivers/serial/serial_core.c.orig	2006-07-13 11:17:49.000000000 -0500
+++ linux-2.6.17/drivers/serial/serial_core.c	2006-07-13 11:23:05.000000000 -0500
@@ -786,6 +786,7 @@ static int uart_set_info(struct uart_sta
 			 * We failed anyway.
 			 */
 			retval = -EBUSY;
+			goto exit;  // Added to return the correct error -Ram Gupta
 		}
 	}
 

Re: [PATCH]drivers: returning proper error from serial driver

[Russell King]

On Thu, Jul 13, 2006 at 11:45:11AM -0500, Ram Gupta wrote:
> This patch fixes the issue of returning 0 even in case of error from
> uart_set_info function.
> Now it returns the  error EBUSY  when it can not set new port. Please apply
> 
> Signed-off-by: Ram Gupta(r.gupta@astronautics.com)

That should be:

Signed-off-by: Ram Gupta <r.gupta@astronautics.com>

and please don't base64 encode patches - it makes applying them
quite difficult with automated tools.  Please resend as per
Documentation/SubmittingPatches, especially section 6.  Thanks.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core