From: Vivek Goyal <vgoyal@in.ibm.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Don Zickus <dzickus@redhat.com>,
fastboot@osdl.org, Horms <horms@verge.net.au>,
Jan Kratochvil <lace@jankratochvil.net>,
"H. Peter Anvin" <hpa@zytor.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Fastboot] [CFT] ELF Relocatable x86 and x86_64 bzImages
Date: Thu, 10 Aug 2006 09:13:23 -0400 [thread overview]
Message-ID: <20060810131323.GB9888@in.ibm.com> (raw)
In-Reply-To: <m1u04l2kaz.fsf@ebiederm.dsl.xmission.com>
On Thu, Aug 10, 2006 at 12:09:56AM -0600, Eric W. Biederman wrote:
> Don Zickus <dzickus@redhat.com> writes:
>
> >> Looking at my build it appears bytes_out is being placed in the .bss.
> >> A little odd since it is zero initialized but no big deal.
> >> Could you confirm that bytes_out is being placed in the .bss section
> >> by inspecting arch/x86_64/boot/compresssed/misc.o and
> >> arch/x86_64/boot_compressed/vmlinux. "readelf -a $file" and then
> >> looking up the section number and looking at the section table to see
> >> which section it is was my technique.
> >>
> >> If bytes_out is in the .bss for you then I suspect something is not
> >> correctly zeroing the .bss. Or else the .bss is being stomped.
> >>
> >> I'm not certain how rep stosb can be done wrong but some bad pointer
> >> math could have done it.
> >>
> >> Eric
> >
> > It seems Vivek came up with a solution that works. He sent it to me this
> > morning. We tested a bunch of machines and things seem to work now. It
> > looks like it mimics the i386 behaviour now.
>
> Yes, this looks right. It looks like I forgot to make this change when
> the logic from i386 was adopted to x86_64, ages ago.
>
> This is exactly the place in the code I would have expected a bug
> from the symptoms you were seeing.
>
> Thanks all I will include this in my version of the patches.
Apart from this I think something is still off on x86_64. I have not
been able to make kdump work on x86_64. Second kernel simply hangs.
Two different machines are showing different results.
- On one machine, it seems to be stuck somewhere in decompress_kernel().
Serial console is not behaving properly even with earlyprintk(). Somehow
I feel it is some bss corruption even after my changes.
- Other machines seems to be going till start_kernel() and even after
that (No messages on the console, all serial debugging) and then
either it hangs or jumps back to BIOS.
Will look more into it.
Thanks
Vivek
next prev parent reply other threads:[~2006-08-10 13:13 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <aec7e5c30606300145p441d8d0xd89fab5e87de5a22@mail.gmail.com>
[not found] ` <20060705222448.GC992@in.ibm.com>
[not found] ` <aec7e5c30607051932r49bbcc7eh2c190daa06859dcc@mail.gmail.com>
[not found] ` <20060706081520.GB28225@host0.dyn.jankratochvil.net>
[not found] ` <aec7e5c30607070147g657d2624qa93a145dd4515484@mail.gmail.com>
[not found] ` <20060707133518.GA15810@in.ibm.com>
[not found] ` <20060707143519.GB13097@host0.dyn.jankratochvil.net>
[not found] ` <20060710233219.GF16215@in.ibm.com>
[not found] ` <20060711010815.GB1021@host0.dyn.jankratochvil.net>
[not found] ` <m1d5c92yv4.fsf@ebiederm.dsl.xmission.com>
2006-07-31 16:19 ` Eric W. Biederman
2006-07-31 20:25 ` Vivek Goyal
2006-07-31 21:00 ` [Fastboot] " Vivek Goyal
2006-08-01 2:31 ` Eric W. Biederman
2006-08-01 2:34 ` H. Peter Anvin
2006-08-01 3:44 ` Eric W. Biederman
2006-08-01 4:25 ` Jan Kratochvil
2006-08-01 9:09 ` Eric W. Biederman
2006-08-01 9:43 ` Jan Kratochvil
2006-08-01 11:28 ` Eric W. Biederman
2006-08-04 21:08 ` Don Zickus
2006-08-04 21:25 ` Eric W. Biederman
2006-08-04 23:43 ` Don Zickus
2006-08-05 7:49 ` Eric W. Biederman
2006-08-05 16:07 ` Eric W. Biederman
2006-08-07 17:44 ` Don Zickus
2006-08-07 18:08 ` Eric W. Biederman
2006-08-07 23:57 ` Don Zickus
2006-08-08 5:01 ` Eric W. Biederman
2006-08-08 19:36 ` Don Zickus
2006-08-09 20:06 ` Don Zickus
2006-08-10 6:09 ` Eric W. Biederman
2006-08-10 13:13 ` Vivek Goyal [this message]
2006-08-10 17:05 ` Eric W. Biederman
2006-08-10 18:18 ` Vivek Goyal
2006-08-10 20:09 ` Eric W. Biederman
2006-08-11 21:25 ` Don Zickus
2006-08-12 7:20 ` Eric W. Biederman
2006-08-12 15:25 ` Don Zickus
2006-08-12 19:41 ` Eric W. Biederman
2006-08-13 20:06 ` Andi Kleen
2006-08-13 21:44 ` Eric W. Biederman
2006-08-14 16:51 ` [Fastboot] " Vivek Goyal
2006-08-14 17:04 ` H. Peter Anvin
2006-08-14 18:11 ` Vivek Goyal
2006-08-14 19:32 ` H. Peter Anvin
2006-08-14 19:42 ` Vivek Goyal
2006-08-14 19:45 ` H. Peter Anvin
2006-08-14 19:57 ` Vivek Goyal
2006-08-14 20:10 ` Eric W. Biederman
2006-08-14 20:59 ` Vivek Goyal
2006-08-14 21:15 ` Eric W. Biederman
2006-08-14 20:00 ` Eric W. Biederman
2006-08-08 23:36 ` Andi Kleen
2006-08-25 20:16 ` Vivek Goyal
[not found] <6EIOG-2xY-31@gated-at.bofh.it>
[not found] ` <6EIOG-2xY-33@gated-at.bofh.it>
[not found] ` <6EIOG-2xY-35@gated-at.bofh.it>
[not found] ` <6EIOG-2xY-37@gated-at.bofh.it>
[not found] ` <6EIOG-2xY-39@gated-at.bofh.it>
[not found] ` <6EIOG-2xY-19@gated-at.bofh.it>
[not found] ` <6Gf5M-2zt-23@gated-at.bofh.it>
[not found] ` <6Gfpt-30C-49@gated-at.bofh.it>
[not found] ` <6GhAA-6bP-19@gated-at.bofh.it>
[not found] ` <6Gx2C-436-5@gated-at.bofh.it>
[not found] ` <6HhoT-5E7-33@gated-at.bofh.it>
[not found] ` <6HhRQ-6uk-3@gated-at.bofh.it>
2006-08-09 12:40 ` [Fastboot] " Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060810131323.GB9888@in.ibm.com \
--to=vgoyal@in.ibm.com \
--cc=dzickus@redhat.com \
--cc=ebiederm@xmission.com \
--cc=fastboot@osdl.org \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=lace@jankratochvil.net \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®