mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: vgoyal@in.ibm.com
Cc: Don Zickus <dzickus@redhat.com>,
	fastboot@osdl.org, Horms <horms@verge.net.au>,
	Jan Kratochvil <lace@jankratochvil.net>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [Fastboot] [CFT] ELF Relocatable x86 and x86_64 bzImages
Date: Thu, 10 Aug 2006 14:09:58 -0600	[thread overview]
Message-ID: <m1irl01hex.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20060810181825.GD14732@in.ibm.com> (Vivek Goyal's message of "Thu, 10 Aug 2006 14:18:25 -0400")

Vivek Goyal <vgoyal@in.ibm.com> writes:

> On Thu, Aug 10, 2006 at 11:05:22AM -0600, Eric W. Biederman wrote:
>> Vivek Goyal <vgoyal@in.ibm.com> writes:
>> 
>> > Apart from this I think something is still off on x86_64. I have not
>> > been able to make kdump work on x86_64. Second kernel simply hangs.
>> > Two different machines are showing different results.
>> >
>> > - On one machine, it seems to be stuck somewhere in decompress_kernel().
>> >   Serial console is not behaving properly even with earlyprintk(). Somehow
>> >   I feel it is some bss corruption even after my changes.
>> >
>> > - Other machines seems to be going till start_kernel() and even after
>> >   that (No messages on the console, all serial debugging) and then
>> >   either it hangs or jumps back to BIOS.
>> >
>> > Will look more into it.
>> 
>> Thanks.
>> 
>> I'm a little disappointed but at this point it isn't a great surprise,
>> the code is early yet and hasn't had much testing or attention.
>> I wonder if I have missed something else silly.
>> 
>> As for testing, can you use plain kexec to load the kernel at a
>> different address?  I'm curious to know if it is something related
>> to the kexec on panic path or if it is just running at a different
>> location that is the problem.
>
> Yes. This seems to be minor stuff. Parameter segment seems to be
> getting stomped while I am doing decompression. Most probably should
> be coming from extra space calculations (32K etc) being done at run
> time to find out where should we shift the compressed image.
>
> Kexec works because parameter segment is being loaded below the
> compressed image and doest not get stomped over. :-) 

Ah.  That makes sense.

> I just reserved memory at non 2MB aligned location 65MB@15MB so that
> kernel is loaded at 16MB and other smaller segments below the compressed
> image, then I can successfully booted into the kdump kernel.

:)

> So basically kexec on panic path seems to be clean except stomping issue.
> May be bzImage program header should reflect right "MemSize" which
> takes into account extra memory space calculations.

Yes.  That sounds like the right thing to do.  

I remember trying to compute a good memsize when I created the bzImage
header but it is completely possible I missed some part of the
calculation or assumed that the kernels .bss section would always be
larger than what I needed for decompression.

Eric

  reply	other threads:[~2006-08-10 20:11 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <aec7e5c30606300145p441d8d0xd89fab5e87de5a22@mail.gmail.com>
     [not found] ` <20060705222448.GC992@in.ibm.com>
     [not found]   ` <aec7e5c30607051932r49bbcc7eh2c190daa06859dcc@mail.gmail.com>
     [not found]     ` <20060706081520.GB28225@host0.dyn.jankratochvil.net>
     [not found]       ` <aec7e5c30607070147g657d2624qa93a145dd4515484@mail.gmail.com>
     [not found]         ` <20060707133518.GA15810@in.ibm.com>
     [not found]           ` <20060707143519.GB13097@host0.dyn.jankratochvil.net>
     [not found]             ` <20060710233219.GF16215@in.ibm.com>
     [not found]               ` <20060711010815.GB1021@host0.dyn.jankratochvil.net>
     [not found]                 ` <m1d5c92yv4.fsf@ebiederm.dsl.xmission.com>
2006-07-31 16:19                   ` Eric W. Biederman
2006-07-31 20:25                     ` Vivek Goyal
2006-07-31 21:00                       ` [Fastboot] " Vivek Goyal
2006-08-01  2:31                         ` Eric W. Biederman
2006-08-01  2:34                           ` H. Peter Anvin
2006-08-01  3:44                             ` Eric W. Biederman
2006-08-01  4:25                           ` Jan Kratochvil
2006-08-01  9:09                             ` Eric W. Biederman
2006-08-01  9:43                               ` Jan Kratochvil
2006-08-01 11:28                                 ` Eric W. Biederman
2006-08-04 21:08                     ` Don Zickus
2006-08-04 21:25                       ` Eric W. Biederman
2006-08-04 23:43                         ` Don Zickus
2006-08-05  7:49                           ` Eric W. Biederman
2006-08-05 16:07                           ` Eric W. Biederman
2006-08-07 17:44                             ` Don Zickus
2006-08-07 18:08                               ` Eric W. Biederman
2006-08-07 23:57                                 ` Don Zickus
2006-08-08  5:01                                   ` Eric W. Biederman
2006-08-08 19:36                                     ` Don Zickus
2006-08-09 20:06                                     ` Don Zickus
2006-08-10  6:09                                       ` Eric W. Biederman
2006-08-10 13:13                                         ` Vivek Goyal
2006-08-10 17:05                                           ` Eric W. Biederman
2006-08-10 18:18                                             ` Vivek Goyal
2006-08-10 20:09                                               ` Eric W. Biederman [this message]
2006-08-11 21:25                                                 ` Don Zickus
2006-08-12  7:20                                                   ` Eric W. Biederman
2006-08-12 15:25                                                     ` Don Zickus
2006-08-12 19:41                                                       ` Eric W. Biederman
2006-08-13 20:06                                                     ` Andi Kleen
2006-08-13 21:44                                                       ` Eric W. Biederman
2006-08-14 16:51                                                 ` [Fastboot] " Vivek Goyal
2006-08-14 17:04                                                   ` H. Peter Anvin
2006-08-14 18:11                                                     ` Vivek Goyal
2006-08-14 19:32                                                       ` H. Peter Anvin
2006-08-14 19:42                                                         ` Vivek Goyal
2006-08-14 19:45                                                           ` H. Peter Anvin
2006-08-14 19:57                                                             ` Vivek Goyal
2006-08-14 20:10                                                             ` Eric W. Biederman
2006-08-14 20:59                                                               ` Vivek Goyal
2006-08-14 21:15                                                                 ` Eric W. Biederman
2006-08-14 20:00                                                     ` Eric W. Biederman
2006-08-08 23:36                                   ` Andi Kleen
2006-08-25 20:16                     ` Vivek Goyal
     [not found] <6EIOG-2xY-31@gated-at.bofh.it>
     [not found] ` <6EIOG-2xY-33@gated-at.bofh.it>
     [not found]   ` <6EIOG-2xY-35@gated-at.bofh.it>
     [not found]     ` <6EIOG-2xY-37@gated-at.bofh.it>
     [not found]       ` <6EIOG-2xY-39@gated-at.bofh.it>
     [not found]         ` <6EIOG-2xY-19@gated-at.bofh.it>
     [not found]           ` <6Gf5M-2zt-23@gated-at.bofh.it>
     [not found]             ` <6Gfpt-30C-49@gated-at.bofh.it>
     [not found]               ` <6GhAA-6bP-19@gated-at.bofh.it>
     [not found]                 ` <6Gx2C-436-5@gated-at.bofh.it>
     [not found]                   ` <6HhoT-5E7-33@gated-at.bofh.it>
     [not found]                     ` <6HhRQ-6uk-3@gated-at.bofh.it>
2006-08-09 12:40                       ` [Fastboot] " Bodo Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1irl01hex.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=dzickus@redhat.com \
    --cc=fastboot@osdl.org \
    --cc=horms@verge.net.au \
    --cc=hpa@zytor.com \
    --cc=lace@jankratochvil.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=vgoyal@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome