From: Jesper Juhl <jesper.juhl@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Karsten Keil <kkeil@suse.de>,
Kai Germaschewski <kai.germaschewski@gmx.de>,
isdn4linux@listserv.isdn4linux.de,
Jesper Juhl <jesper.juhl@gmail.com>
Subject: [PATCH] ISDN: fix double free bug in isdn_net
Date: Sat, 12 Aug 2006 22:48:22 +0200 [thread overview]
Message-ID: <200608122248.22639.jesper.juhl@gmail.com> (raw)
There's double-free bug in
drivers/isdn/i4l/isdn_net.c::isdn_net_writebuf_skb().
If isdn_writebuf_skb_stub() doesn't handle the entire skb, then it will
have freed the skb that was passed to it and when the code then jumps
to the error label it'll result in a double free of the skb.
The easy way to fix this is to insert an assignment of skb = NULL in the
'if' following the call to isdn_writebuf_skb_stub() so that when the code
at the error label calls dev_kfree_skb(skb); the skb will be NULL and
nothing will happen since dev_kfree_skb() just does a return if passed a
NULL.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
drivers/isdn/i4l/isdn_net.c | 1 +
1 files changed, 1 insertion(+)
--- linux-2.6.18-rc4-orig/drivers/isdn/i4l/isdn_net.c 2006-08-11 00:10:55.000000000 +0200
+++ linux-2.6.18-rc4/drivers/isdn/i4l/isdn_net.c 2006-08-12 22:39:56.000000000 +0200
@@ -1023,6 +1023,7 @@ void isdn_net_writebuf_skb(isdn_net_loca
if (ret != len) {
/* we should never get here */
printk(KERN_WARNING "%s: HL driver queue full\n", lp->name);
+ skb = NULL;
goto error;
}
next reply other threads:[~2006-08-12 20:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-12 20:48 Jesper Juhl [this message]
2006-08-15 9:00 ` David Miller
2006-08-15 9:08 ` Jesper Juhl
2006-08-15 9:15 ` David Miller
2006-08-15 10:42 ` Jesper Juhl
2006-08-15 16:06 ` Karsten Keil
2006-08-16 20:22 ` Jesper Juhl
2006-08-16 20:39 ` Karsten Keil
2006-08-16 20:44 ` David Miller
2006-08-16 20:48 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608122248.22639.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kai.germaschewski@gmx.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®